Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature: Remove on/off options from feedbacks #75

Open
arikorn opened this issue Feb 13, 2025 · 2 comments
Open

Feature: Remove on/off options from feedbacks #75

arikorn opened this issue Feb 13, 2025 · 2 comments

Comments

@arikorn
Copy link

arikorn commented Feb 13, 2025

This is probably a low-priority issue but worth keeping in mind, especially for new feedbacks:

For boolean-valued feedbacks (which is perhaps all of them?) there's no need to provide options for on/off since Companion has a built-in "invert" logic button. So the corresponding on/off dropdown menus could be eliminated.

@fa1k3n
Copy link
Collaborator

fa1k3n commented Feb 14, 2025

agreed. What should the feebacks be called. "Change style of button depending on state of ...." , Thinking its easy to miss in feedback list if its called "Change style of button when ... is true" then probably many will look for the "false" feedback not realizing they should invert to "true" action

@arikorn
Copy link
Author

arikorn commented Feb 15, 2025

@fa1k3n , I think for the most part the names can be the same, or with words like "on" or "selected" appended.
Then the description just explains what it does: "Change button style when feature is on" or some such.

Partly related: many (?) of the feedbacks have descriptions copied from the action. These should be cleaned up as well.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants