Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FEATURE] Enable the use of a custom template for notFoundEntries #381

Closed
ruekart opened this issue Jun 10, 2022 · 4 comments · Fixed by #382
Closed

[FEATURE] Enable the use of a custom template for notFoundEntries #381

ruekart opened this issue Jun 10, 2022 · 4 comments · Fixed by #382

Comments

@ruekart
Copy link
Contributor

ruekart commented Jun 10, 2022

Is your feature request related to a problem? Please describe.
When there are no options found for the user input then there's just the possibility to show a not found label, but sometimes you could want to add more than text, it could be an image or a button.

Describe the solution you'd like
I would like to use ng-content to show a custom element when there are no options as with the custom clear icon.

Describe alternatives you've considered
I have considered to add an EventEmitter as pointed out in #345 but I think it could be confusing for the user to know the option to press enter to add a new element or something else.

Additional context
Here there are some not found messages with custom content
image

image

@macjohnny
Copy link
Member

This sounds good. We could use a directive similar to https://github.com/bithost-gmbh/ngx-mat-select-search/blob/master/src/app/mat-select-search/mat-select-search-clear.directive.ts to mark the content.

Do you want to implement this?

@ruekart
Copy link
Contributor Author

ruekart commented Jun 13, 2022

Sure, I'm working on it.

@ruekart
Copy link
Contributor Author

ruekart commented Jun 13, 2022

I sent this PR #382

@macjohnny
Copy link
Member

thanks for your contribution. it is released in version 4.2.0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants