Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

API change for bridge.Transform.from_points #1107

Open
bjlittle opened this issue Sep 18, 2024 · 1 comment
Open

API change for bridge.Transform.from_points #1107

bjlittle opened this issue Sep 18, 2024 · 1 comment
Labels
breaking-change Auto-labelled for break/*, breaking/* and breaking-change/* branches new: issue Highlight a new community raised "generic" issue

Comments

@bjlittle
Copy link
Owner

bjlittle commented Sep 18, 2024 •
edited
Loading

📰 Custom Issue

Align the use of the zlevels kwargs for geovista.bridge.Transform.from_points with the rest of the Transform API i.e., drop support for this being an array of values.

Support optional zs instead. See the point cloud use case.

This change will underpin follow-on work to the Transform API such that it supports volumes rather than surfaces, see #15.

Note, also impacts geovista.common.to_cartesian.
@bjlittle bjlittle added the new: issue Highlight a new community raised "generic" issue label Sep 18, 2024
@welcome Welcome
Copy link

welcome bot commented Sep 18, 2024

📢 Nice one! Your first issue! Thanks for telling us how to improve geovista 📢

@bjlittle bjlittle added the breaking-change Auto-labelled for break/*, breaking/* and breaking-change/* branches label Sep 18, 2024
@bjlittle bjlittle moved this to 📚 Backlog in 🦊 GeoVista v0.6.0 Sep 18, 2024
@bjlittle bjlittle changed the title Change bridge.Transform.from_points API API change for bridge.Transform.from_points Sep 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
breaking-change Auto-labelled for break/*, breaking/* and breaking-change/* branches new: issue Highlight a new community raised "generic" issue
Projects
🦊 GeoVista v0.6.0
Status: 📚 Backlog
Milestone
No milestone
Development

No branches or pull requests
1 participant
@bjlittle