Inline comments throwing lexical parsing exceptions

[dswitzer]

Are there any plans to support the inline comment styles in newer versions of Liquid?

For example:

{%- # This is a single-line comment -%}

and

{%
  ###############################
  # This is a comment
  # across multiple lines
  ###############################
%}

Currently these styles of comments are throwing lexical parsing exceptions like:

lexer error "token recognition error at: '#'" on line 1, index 7

[bkiers]

I think the linked PR does the trick. However, I've not been really active here lately, so I'll leave the merge (and release) to @msangel

[dswitzer]

@bkiers,

Amazing! Thanks!

[msangel]

Released as 0.9.2.0. Maven will take few hours to sync for this library available for all

[bkiers]

Thanks @msangel 👌

[dswitzer]

Many thanks to you both (@bkiers & @msangel)!!!

I will test this later today.

[dswitzer]

I finally got a chance to test this, and 0.9.2.0 is still throwing exceptions when processing the following:

{% # for i in (1..3) -%}
{{ i }}
{% # endfor %}

{%
  ###############################
  # This is a comment
  # across multiple lines
  ###############################
%}

According to the documentation (https://shopify.github.io/liquid/tags/template/#inline-comments) this should be allowed.

I've tried both LIQP and LIQUID flavors and get the same error.

It's possible I'm missing something simple in my configuration, but the template parses correct without those styles of comments.

[bkiers]

Just noticed your last comment. I will have a look.

[dswitzer]

@bkiers,

Just wondering if you had a chance to look at this yet? I really appreciate you taking the time to even submit a PR to include this and can only imagine how busy you are. Thanks!

[bkiers]

Ah, I see what is going wrong.