Change to -pedantic needs Eclipse restart

[chrisrueger]

During recent work with pedantic warnings I noticed a behavior that a change to -pendatic (e.g. in cnf/build.bnd) requires a Eclipse restart.
Reload workspace button

is not enough.

Analysis

I believe the reason is related to this:

• pedantic is mainly set in aQute.bnd.osgi.Processor.begin()

bnd/biz.aQute.bndlib/src/aQute/bnd/osgi/Processor.java

Lines 1036 to 1038 in 2ec2d15

	protected void begin() {
	if (isTrue(getProperty(PEDANTIC)))
	setPedantic(true);

• which is called by

a) aQute.bnd.osgi.Processor.getProperties()

bnd/biz.aQute.bndlib/src/aQute/bnd/osgi/Processor.java

Lines 635 to 638 in 2ec2d15

	public Properties getProperties() {
	if (fixup) {
	fixup = false;
	begin();

and

b) aQute.bnd.osgi.Analyzer.begin() (calls super.begin())

bnd/biz.aQute.bndlib/src/aQute/bnd/osgi/Analyzer.java

Lines 1777 to 1780 in 2ec2d15

	protected void begin() {
	if (inited == false) {
	inited = true;
	super.begin();

The problem is those methods are guarded by the flag boolean Processor.fixup and boolean Analyzer.inited, which are only set once in those methods and never reset.
Basically this means that pedantic is only set when the Workspace is initialized.
The Workspace reload button does not have the same effect -it seems to reload every other properties, but not -pedantic seems to be a different thing.

Question:
Is this by design?

[chrisrueger]

As discussed with @pkriens the fixup and inited flags should be reset on Workspace-refresh too ( )

So I will try to find a way.

[kriegfrj]

Just as a suggestion of where to look: Does this perhaps have anything to do with the fact that the Bnd Workspace object is memoized in bndtools.CentralThis could be due to the fact that the Bnd Workspace object is memoized on startup in bndtools.centra.Central and kept in memory? A change to pedantic in build.bnd would need to be detected and updated in the in-memory copy of Workspace for it to take effect in subsequent Bndtools builds.

[chrisrueger]

Just as a suggestion of where to look: Does this perhaps have anything to do with the fact that the Bnd Workspace object is memoized in bndtools.CentralThis could be due to the fact that the Bnd Workspace object is memoized on startup in bndtools.centra.Central and kept in memory? A change to pedantic in build.bnd would need to be detected and updated in the in-memory copy of Workspace for it to take effect in subsequent Bndtools builds.

Thanks @kriegfrj thats likely true somehow. I tried various approaches but I couldn't figure it out.
I gave up and just propose adding a hint in #6511