diff --git a/RSTALanguageSupport/src/main/java/org/fife/rsta/ac/js/ast/jsType/RhinoJavaScriptTypesFactory.java b/RSTALanguageSupport/src/main/java/org/fife/rsta/ac/js/ast/jsType/RhinoJavaScriptTypesFactory.java index cd6bae25..1ef92247 100644 --- a/RSTALanguageSupport/src/main/java/org/fife/rsta/ac/js/ast/jsType/RhinoJavaScriptTypesFactory.java +++ b/RSTALanguageSupport/src/main/java/org/fife/rsta/ac/js/ast/jsType/RhinoJavaScriptTypesFactory.java @@ -22,8 +22,8 @@ */ public class RhinoJavaScriptTypesFactory extends JSR223JavaScriptTypesFactory { - private LinkedHashSet importClasses = new LinkedHashSet<>(); - private LinkedHashSet importPackages = new LinkedHashSet<>(); + private Set importClasses = new LinkedHashSet<>(); + private Set importPackages = new LinkedHashSet<>(); public RhinoJavaScriptTypesFactory(TypeDeclarationFactory typesFactory) { super(typesFactory); @@ -43,9 +43,9 @@ public void mergeImports(Set packages, Set classes) { mergeImports(classes, importClasses, false); } - private void mergeImports(Set newImports, LinkedHashSet oldImports, boolean packages) { + private void mergeImports(Set newImports, Set oldImports, boolean packages) { //iterate through the old imports and check whether the import exists in new. If not then add to remove and remove all types for that package/class - HashSet remove = new HashSet<>(); + Set remove = new HashSet<>(); for (String obj : oldImports) { if (!newImports.contains(obj)) { remove.add(obj); @@ -55,7 +55,7 @@ private void mergeImports(Set newImports, LinkedHashSet oldImpor //now iterate through the remove list and remove imports not needed if (!remove.isEmpty()) { - HashSet removeTypes = new HashSet<>(); + Set removeTypes = new HashSet<>(); for (String name : remove) { for (TypeDeclaration dec : cachedTypes.keySet()) { if ((packages && dec.getQualifiedName().startsWith(name)) || (!packages && dec.getQualifiedName().equals(name))) { @@ -84,7 +84,7 @@ private void mergeImports(Set newImports, LinkedHashSet oldImpor * @param oldImports * @return */ - private boolean canClearCache(Set newImports, LinkedHashSet oldImports) { + private boolean canClearCache(Set newImports, Set oldImports) { if (newImports.size() != oldImports.size()) { return true; } @@ -105,7 +105,7 @@ public void clearImportCache() { } private void clearAllImportTypes() { - HashSet removeTypes = new HashSet<>(); + Set removeTypes = new HashSet<>(); //clear all non ECMA (JavaScript types) for importPackage and importClass to work properly for (TypeDeclaration dec : cachedTypes.keySet()) { if (!typesFactory.isJavaScriptType(dec) && !dec.equals(typesFactory.getDefaultTypeDeclaration())) { diff --git a/RSTALanguageSupport/src/main/java/org/fife/rsta/ac/js/ast/parser/RhinoJavaScriptAstParser.java b/RSTALanguageSupport/src/main/java/org/fife/rsta/ac/js/ast/parser/RhinoJavaScriptAstParser.java index b8f79055..32b92227 100644 --- a/RSTALanguageSupport/src/main/java/org/fife/rsta/ac/js/ast/parser/RhinoJavaScriptAstParser.java +++ b/RSTALanguageSupport/src/main/java/org/fife/rsta/ac/js/ast/parser/RhinoJavaScriptAstParser.java @@ -23,8 +23,8 @@ public class RhinoJavaScriptAstParser extends JavaScriptAstParser { public static final String PACKAGES = "Packages."; - private LinkedHashSet importClasses = new LinkedHashSet<>(); - private LinkedHashSet importPackages = new LinkedHashSet<>(); + private Set importClasses = new LinkedHashSet<>(); + private Set importPackages = new LinkedHashSet<>(); public RhinoJavaScriptAstParser(SourceCompletionProvider provider, int dot, TypeDeclarationOptions options) { diff --git a/RSTALanguageSupport/src/main/java/org/fife/rsta/ac/js/ast/type/ecma/TypeDeclarations.java b/RSTALanguageSupport/src/main/java/org/fife/rsta/ac/js/ast/type/ecma/TypeDeclarations.java index ae347d1b..f67082c9 100644 --- a/RSTALanguageSupport/src/main/java/org/fife/rsta/ac/js/ast/type/ecma/TypeDeclarations.java +++ b/RSTALanguageSupport/src/main/java/org/fife/rsta/ac/js/ast/type/ecma/TypeDeclarations.java @@ -40,7 +40,7 @@ public abstract class TypeDeclarations { // reverse lookup for Java types to Javascript types private final Map javascriptReverseLookup = new HashMap<>(); - private final HashSet ecmaObjects = new HashSet<>(); + private final Set ecmaObjects = new HashSet<>(); public TypeDeclarations() { diff --git a/config/checkstyle/lsSuppressions.xml b/config/checkstyle/lsSuppressions.xml index 9ee90731..ecdba656 100644 --- a/config/checkstyle/lsSuppressions.xml +++ b/config/checkstyle/lsSuppressions.xml @@ -11,7 +11,7 @@ For now we're ignoring several issues that will take some time to address. TODO: Remove these issues one by one. --> - +