From 885b37ce671261dec3ad74ae683041a4ce0a773b Mon Sep 17 00:00:00 2001 From: bobbylight Date: Sat, 21 Jun 2025 23:22:03 -0400 Subject: [PATCH] Enable checkstyle ExplicitInitialization rule for JS support --- .../java/org/fife/rsta/ac/js/JavaScriptHelper.java | 2 +- .../fife/rsta/ac/js/SourceCompletionProvider.java | 4 ++-- .../ac/js/ast/jsType/JavaScriptFunctionType.java | 12 ++++++------ .../ac/js/resolver/JavaScriptCompletionResolver.java | 2 +- .../ac/js/tree/JavaScriptOutlineTreeGenerator.java | 2 +- config/checkstyle/lsSuppressions.xml | 2 +- 6 files changed, 12 insertions(+), 12 deletions(-) diff --git a/RSTALanguageSupport/src/main/java/org/fife/rsta/ac/js/JavaScriptHelper.java b/RSTALanguageSupport/src/main/java/org/fife/rsta/ac/js/JavaScriptHelper.java index 6dbf9c74..032f5d3a 100644 --- a/RSTALanguageSupport/src/main/java/org/fife/rsta/ac/js/JavaScriptHelper.java +++ b/RSTALanguageSupport/src/main/java/org/fife/rsta/ac/js/JavaScriptHelper.java @@ -355,7 +355,7 @@ public static boolean isInfixOnly(AstNode typeNode) { */ private static final class InfixVisitor implements NodeVisitor { - private String type = null; + private String type; private SourceCompletionProvider provider; private InfixVisitor(SourceCompletionProvider provider) { diff --git a/RSTALanguageSupport/src/main/java/org/fife/rsta/ac/js/SourceCompletionProvider.java b/RSTALanguageSupport/src/main/java/org/fife/rsta/ac/js/SourceCompletionProvider.java index 1849dd5d..4ee7e850 100644 --- a/RSTALanguageSupport/src/main/java/org/fife/rsta/ac/js/SourceCompletionProvider.java +++ b/RSTALanguageSupport/src/main/java/org/fife/rsta/ac/js/SourceCompletionProvider.java @@ -120,8 +120,8 @@ public void setShorthandCache(ShorthandCompletionCache shorthandCache) { } - private String lastCompletionsAtText = null; - private List lastParameterizedCompletionsAt = null; + private String lastCompletionsAtText; + private List lastParameterizedCompletionsAt; @Override public List getCompletionsAt(JTextComponent tc, Point p) { diff --git a/RSTALanguageSupport/src/main/java/org/fife/rsta/ac/js/ast/jsType/JavaScriptFunctionType.java b/RSTALanguageSupport/src/main/java/org/fife/rsta/ac/js/ast/jsType/JavaScriptFunctionType.java index 01f00688..46330c65 100644 --- a/RSTALanguageSupport/src/main/java/org/fife/rsta/ac/js/ast/jsType/JavaScriptFunctionType.java +++ b/RSTALanguageSupport/src/main/java/org/fife/rsta/ac/js/ast/jsType/JavaScriptFunctionType.java @@ -30,12 +30,12 @@ public final class JavaScriptFunctionType { public static Class ShortClass = Kit.classOrNull("java.lang.Short"); public static Class StringClass = Kit.classOrNull("java.lang.String"); public static Class DateClass = Kit.classOrNull("java.util.Date"); - public static Class JSBooleanClass = null; - public static Class JSStringClass = null; - public static Class JSNumberClass = null; - public static Class JSObjectClass = null; - public static Class JSDateClass = null; - public static Class JSArray = null; + public static Class JSBooleanClass; + public static Class JSStringClass; + public static Class JSNumberClass; + public static Class JSObjectClass; + public static Class JSDateClass; + public static Class JSArray; private String name; private List arguments; diff --git a/RSTALanguageSupport/src/main/java/org/fife/rsta/ac/js/resolver/JavaScriptCompletionResolver.java b/RSTALanguageSupport/src/main/java/org/fife/rsta/ac/js/resolver/JavaScriptCompletionResolver.java index 5d7764c3..cd15d464 100644 --- a/RSTALanguageSupport/src/main/java/org/fife/rsta/ac/js/resolver/JavaScriptCompletionResolver.java +++ b/RSTALanguageSupport/src/main/java/org/fife/rsta/ac/js/resolver/JavaScriptCompletionResolver.java @@ -43,7 +43,7 @@ public class JavaScriptCompletionResolver extends JavaScriptResolver { protected JavaScriptType lastJavaScriptType; - protected String lastLookupName = null; + protected String lastLookupName; /** diff --git a/RSTALanguageSupport/src/main/java/org/fife/rsta/ac/js/tree/JavaScriptOutlineTreeGenerator.java b/RSTALanguageSupport/src/main/java/org/fife/rsta/ac/js/tree/JavaScriptOutlineTreeGenerator.java index c7661af7..5b3b8561 100644 --- a/RSTALanguageSupport/src/main/java/org/fife/rsta/ac/js/tree/JavaScriptOutlineTreeGenerator.java +++ b/RSTALanguageSupport/src/main/java/org/fife/rsta/ac/js/tree/JavaScriptOutlineTreeGenerator.java @@ -52,7 +52,7 @@ class JavaScriptOutlineTreeGenerator implements NodeVisitor { private JavaScriptTreeNode curScopeTreeNode; - private Map> prototypeAdditions = null; + private Map> prototypeAdditions; JavaScriptOutlineTreeGenerator(RSyntaxTextArea textArea, diff --git a/config/checkstyle/lsSuppressions.xml b/config/checkstyle/lsSuppressions.xml index 322b5041..d5bd3cfe 100644 --- a/config/checkstyle/lsSuppressions.xml +++ b/config/checkstyle/lsSuppressions.xml @@ -11,7 +11,7 @@ For now we're ignoring several issues that will take some time to address. TODO: Remove these issues one by one. --> - +