-
Notifications
You must be signed in to change notification settings - Fork 0
Expand file tree
/
Copy pathbugreports.xml
More file actions
5669 lines (5212 loc) · 286 KB
/
bugreports.xml
File metadata and controls
5669 lines (5212 loc) · 286 KB
1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
174
175
176
177
178
179
180
181
182
183
184
185
186
187
188
189
190
191
192
193
194
195
196
197
198
199
200
201
202
203
204
205
206
207
208
209
210
211
212
213
214
215
216
217
218
219
220
221
222
223
224
225
226
227
228
229
230
231
232
233
234
235
236
237
238
239
240
241
242
243
244
245
246
247
248
249
250
251
252
253
254
255
256
257
258
259
260
261
262
263
264
265
266
267
268
269
270
271
272
273
274
275
276
277
278
279
280
281
282
283
284
285
286
287
288
289
290
291
292
293
294
295
296
297
298
299
300
301
302
303
304
305
306
307
308
309
310
311
312
313
314
315
316
317
318
319
320
321
322
323
324
325
326
327
328
329
330
331
332
333
334
335
336
337
338
339
340
341
342
343
344
345
346
347
348
349
350
351
352
353
354
355
356
357
358
359
360
361
362
363
364
365
366
367
368
369
370
371
372
373
374
375
376
377
378
379
380
381
382
383
384
385
386
387
388
389
390
391
392
393
394
395
396
397
398
399
400
401
402
403
404
405
406
407
408
409
410
411
412
413
414
415
416
417
418
419
420
421
422
423
424
425
426
427
428
429
430
431
432
433
434
435
436
437
438
439
440
441
442
443
444
445
446
447
448
449
450
451
452
453
454
455
456
457
458
459
460
461
462
463
464
465
466
467
468
469
470
471
472
473
474
475
476
477
478
479
480
481
482
483
484
485
486
487
488
489
490
491
492
493
494
495
496
497
498
499
500
501
502
503
504
505
506
507
508
509
510
511
512
513
514
515
516
517
518
519
520
521
522
523
524
525
526
527
528
529
530
531
532
533
534
535
536
537
538
539
540
541
542
543
544
545
546
547
548
549
550
551
552
553
554
555
556
557
558
559
560
561
562
563
564
565
566
567
568
569
570
571
572
573
574
575
576
577
578
579
580
581
582
583
584
585
586
587
588
589
590
591
592
593
594
595
596
597
598
599
600
601
602
603
604
605
606
607
608
609
610
611
612
613
614
615
616
617
618
619
620
621
622
623
624
625
626
627
628
629
630
631
632
633
634
635
636
637
638
639
640
641
642
643
644
645
646
647
648
649
650
651
652
653
654
655
656
657
658
659
660
661
662
663
664
665
666
667
668
669
670
671
672
673
674
675
676
677
678
679
680
681
682
683
684
685
686
687
688
689
690
691
692
693
694
695
696
697
698
699
700
701
702
703
704
705
706
707
708
709
710
711
712
713
714
715
716
717
718
719
720
721
722
723
724
725
726
727
728
729
730
731
732
733
734
735
736
737
738
739
740
741
742
743
744
745
746
747
748
749
750
751
752
753
754
755
756
757
758
759
760
761
762
763
764
765
766
767
768
769
770
771
772
773
774
775
776
777
778
779
780
781
782
783
784
785
786
787
788
789
790
791
792
793
794
795
796
797
798
799
800
801
802
803
804
805
806
807
808
809
810
811
812
813
814
815
816
817
818
819
820
821
822
823
824
825
826
827
828
829
830
831
832
833
834
835
836
837
838
839
840
841
842
843
844
845
846
847
848
849
850
851
852
853
854
855
856
857
858
859
860
861
862
863
864
865
866
867
868
869
870
871
872
873
874
875
876
877
878
879
880
881
882
883
884
885
886
887
888
889
890
891
892
893
894
895
896
897
898
899
900
901
902
903
904
905
906
907
908
909
910
911
912
913
914
915
916
917
918
919
920
921
922
923
924
925
926
927
928
929
930
931
932
933
934
935
936
937
938
939
940
941
942
943
944
945
946
947
948
949
950
951
952
953
954
955
956
957
958
959
960
961
962
963
964
965
966
967
968
969
970
971
972
973
974
975
976
977
978
979
980
981
982
983
984
985
986
987
988
989
990
991
992
993
994
995
996
997
998
999
1000
<root>
<BugReport ID = "1">
<Title>"(495584) Firefox - search suggestions passes wrong previous result to form history"</Title>
<Turn>
<Date>'2009-05-29 20:32:54'</Date>
<From>'Justin Dolske'</From>
<Text>
<Sentence ID = "1.1"> MattN noticed a problem with the WIP patch from bug 469443 applied.</Sentence>
<Sentence ID = "1.2"> When typing in the search box, sometimes search-suggestion entries would be displayed above the divider (where entries for previous matching searches are).</Sentence>
<Sentence ID = "1.3"> The problem here is that nsSearchSuggestions.js is passing the wrong previousResult to form history.</Sentence>
<Sentence ID = "1.4"> Instead of it being the previous form history search result, it's the SuggestAutoCompleteResult result (which contains the union of the form-history and search-suggest entries).</Sentence>
<Sentence ID = "1.5"> So, when form history refines its results as you time, it can actually add *more* entries as data leaks from the suggestions result into form history result, and it thus looks like the divider is being drawn in the wrong place.</Sentence>
<Sentence ID = "1.6"> This bug wasn't visible before 469443, because nsFormFillController::StartSearch tries to QI the provided result to a nsIAutoCompleteSimpleResult. </Sentence>
<Sentence ID = "1.7"> The search-suggestion result is only implements nsIAutoCompletResult (no \"Simple\"), so the QI fails, historyResult nee previousResult becomes null, and thus Satchel was doing a new search every time.</Sentence>
<Sentence ID = "1.8"> EG:</Sentence>
<Sentence ID = "1.9"> 1) type \"b\" in the search field.</Sentence>
<Sentence ID = "1.10"> 2) form history finds 1 entry (\"blah\"), search-suggestions finds \"baaa\", \"bloop\", \"bzzz\", the autocompete menu shows these in order with a divider between \"blah\" and \"baaa\".</Sentence>
<Sentence ID = "1.11"> 3) type an \"l\" in the search field (\"bl\")</Sentence>
<Sentence ID = "1.12"> 4) startHistorySearch()'s previous result contains [\"blah\", \"baaa\", \"bloop\", \"bzzz\"], Satchel filters this down to [\"blah\", \"bloop\"] to match the new \"bl\" search string</Sentence>
<Sentence ID = "1.13"> 5) nsSearchSuggestions's onReadyState() change is called with updated search suggestions, builds up a new list of results, but sees that the form history result now has *two* entries.</Sentence>
</Text>
</Turn>
<Turn>
<Date>'2009-05-29 20:37:31'</Date>
<From>'Justin Dolske'</From>
<Text>
<Sentence ID = "2.1"> Created an attachment (id=380567) [details] Patch v.1 (WIP)</Sentence>
<Sentence ID = "2.2"> This fixes the problem, but isn't quite correct...</Sentence>
<Sentence ID = "2.3"> If you type \"a&lt;backspace&gt;b\", satchel trying to use the results from the \"a\" search for the \"b\" search, and so nothing is found. </Sentence>
<Sentence ID = "2.4"> I suspect nsSearchSuggestions needs to throw away the old form history result when the search string changes like this, but I'm not entirely sure it's responsible for doing so, maybe satchel should be smarter about throwing away a previous result when the previous result's search string doesn't have a common prefix.</Sentence>
<Sentence ID = "2.5"> [That seems to be handled somewhere else for normal form field entries, oddly enough.]</Sentence>
</Text>
</Turn>
<Turn>
<Date>'2009-06-14 18:55:25'</Date>
<From>'Justin Dolske'</From>
<Text>
<Sentence ID = "3.1"> Created an attachment (id=383211) [details] Patch v.2</Sentence>
<Sentence ID = "3.2"> Ah. So, there's a ._formHistoryResult in the SuggestAutoCompleteResult wrapper (used to combine form history with search suggestions), and also a ._formHistoryResult in SuggestAutoComplete (the service itself, used to hold onto a form history result until a search suggestion is available).</Sentence>
<Sentence ID = "3.3"> The simple fix it to just discard the service's form history result copy when startSearch() is called with a null previous result.</Sentence>
<Sentence ID = "3.4"> Otherwise it's trying to use a old form history result that no longer applies for the search string.</Sentence>
</Text>
</Turn>
<Turn>
<Date>'2009-06-19 12:07:34'</Date>
<From>'Gavin Sharp'</From>
<Text>
<Sentence ID = "4.1"> (From update of attachment 383211 [details])</Sentence>
<Sentence ID = "4.2"> Perhaps we should rename one of them to _fhResult just to reduce confusion?</Sentence>
</Text>
</Turn>
<Turn>
<Date>'2009-06-19 13:17:56'</Date>
<From>'Justin Dolske'</From>
<Text>
<Sentence ID = "5.1"> (In reply to comment #3)</Sentence>
<Sentence ID = "5.2"> &gt; (From update of attachment 383211 [details] [details])</Sentence>
<Sentence ID = "5.3"> &gt; Perhaps we should rename one of them to _fhResult just to reduce confusion?</Sentence>
<Sentence ID = "5.4"> Good point.</Sentence>
<Sentence ID = "5.5"> I renamed the one in the wrapper to _formHistResult. </Sentence>
<Sentence ID = "5.6"> fhResult seemed maybe a bit too short.</Sentence>
</Text>
</Turn>
<Turn>
<Date>'2009-06-19 13:20:52'</Date>
<From>'Justin Dolske'</From>
<Text>
<Sentence ID = "6.1"> Pushed http://hg.mozilla.org/mozilla-central/rev/097598383614</Sentence>
</Text>
</Turn>
</BugReport>
<BugReport ID = "2">
<Title>"(449596) Firefox - remove the browser.sessionstore.enabled pref "</Title>
<Turn>
<Date>'2008-08-07 07:22:12'</Date>
<From>'Simon Bunzli'</From>
<Text>
<Sentence ID = "1.1"> That pref was thought to be for extensions which wanted to completely replace our own Session Restore functionality.</Sentence>
<Sentence ID = "1.2"> While this has worked somehow for Tab Mix Plus, we've had several issues with people ending up both Session Restore and Tab Mix Plus disabled (see bug 435055 and its duplicates).</Sentence>
<Sentence ID = "1.3"> Furthermore, there are several code points which will also break when Session Restore has been disabled (such as the list of recently closed tabs).</Sentence>
<Sentence ID = "1.4"> Instead of adding try-catch-blocks wherever we use Session Restore, I'd much rather encourage extensions authors to override both nsSessionStartup and nsSessionStore to provide the same API with their own functionality (or implementing a dummy-API and making sure for themselves that they've correctly replaced all known consumers).</Sentence>
<Sentence ID = "1.5"> This would also make the lives of those other extension authors simpler who so far can't be too sure that the Session Store component actually works (through whatever implementation).</Sentence>
<Sentence ID = "1.6"> Note that privacy concerned users will still be able to disable writing to sessionstore.js through the browser.sessionstore.resume_from_crash pref.</Sentence>
</Text>
</Turn>
<Turn>
<Date>'2008-08-07 07:42:37'</Date>
<From>'Simon Bunzli'</From>
<Text>
<Sentence ID = "2.1"> Created an attachment (id=332726) [details] </Sentence>
<Sentence ID = "2.2"> remove the pref</Sentence>
</Text>
</Turn>
<Turn>
<Date>'2008-08-13 11:37:55'</Date>
<From>'Nickolay Ponomarev '</From>
<Text>
<Sentence ID = "3.1"> (note: bug 448725 should be wontfixed if this is fixed)</Sentence>
</Text>
</Turn>
<Turn>
<Date>'2008-08-14 14:08:24'</Date>
<From>'Simon Bunzli'</From>
<Text>
<Sentence ID = "4.1"> Created an attachment (id=333820) [details]</Sentence>
<Sentence ID = "4.2"> remove (buggy) note from API comments</Sentence>
</Text>
</Turn>
<Turn>
<Date>'2008-08-18 14:33:16'</Date>
<From>'Dietrich Ayala'</From>
<Text>
<Sentence ID = "5.1"> (From update of attachment 332726 [details])</Sentence>
<Sentence ID = "5.2"> a problem with this patch is that the session data is still stored in memory while the app is running, and by removing this pref, there's no way to disable that.</Sentence>
<Sentence ID = "5.3"> some users do not want the recently-closed-tabs menu, and others don't want any session tracks stored in memory at all.</Sentence>
</Text>
</Turn>
<Turn>
<Date>'2008-08-18 14:46:25'</Date>
<From>'Simon Bunzli'</From>
<Text>
<Sentence ID = "6.1"> (In reply to comment #4)</Sentence>
<Sentence ID = "6.2"> &gt; some users do not want the recently-closed-tabs menu,</Sentence>
<Sentence ID = "6.3"> That's what browser.sessionstore.max_tabs_undo is for: setting it to 0 effectively disables the feature.</Sentence>
<Sentence ID = "6.4"> &gt; and others don't want any session tracks stored in memory at all.</Sentence>
<Sentence ID = "6.5"> Then again, we don't save any data that wouldn't be in memory, anyway, or do we?</Sentence>
<Sentence ID = "6.6"> I'd rather introduce a different pref or different means to cater the privacy sensitive users than have this half-baked cut-it-all pref which AFAICT so far has produced more issues than it's solved.</Sentence>
</Text>
</Turn>
<Turn>
<Date>'2008-08-19 10:07:17'</Date>
<From>'Dietrich Ayala'</From>
<Text>
<Sentence ID = "7.1"> (In reply to comment #5)</Sentence>
<Sentence ID = "7.2"> &gt; Then again, we don't save any data that wouldn't be in memory, anyway, or do we?</Sentence>
<Sentence ID = "7.3"> Fair point. I'm not sure.</Sentence>
<Sentence ID = "7.4"> &gt; I'd rather introduce a different pref or different means to cater the privacy sensitive users than have this half-baked cut-it-all pref which AFAICT so far has produced more issues than it's solved.</Sentence>
<Sentence ID = "7.5"> Yes, agreed the pref is not ideal for this purpose.</Sentence>
<Sentence ID = "7.6"> So max_tabs_undo=0 + resume_from_crash=false is fine for now, until proper \"private browsing\" is supported.</Sentence>
</Text>
</Turn>
<Turn>
<Date>'2008-08-19 10:12:56'</Date>
<From>'Dietrich Ayala'</From>
<Text>
<Sentence ID = "8.1"> (From update of attachment 332726 [details])</Sentence>
<Sentence ID = "8.2"> &gt;+ // XXXzeniko should't we just disable this item as we disable</Sentence>
<Sentence ID = "8.3"> &gt;+ // the tabbrowser-multiple items above - for consistency?</Sentence>
<Sentence ID = "8.4"> &gt;+ this.mUndoCloseTabMenuItem.hidden =</Sentence>
<Sentence ID = "8.5"> &gt;+ Cc[\"@mozilla.org/browser/sessionstore;1\"].</Sentence>
<Sentence ID = "8.6"> &gt;+ getService(Ci.nsISessionStore).</Sentence>
<Sentence ID = "8.7"> &gt;+ getClosedTabCount(window) == 0;</Sentence>
<Sentence ID = "8.8"> +1</Sentence>
<Sentence ID = "8.9"> r=me</Sentence>
</Text>
</Turn>
<Turn>
<Date>'2008-08-19 10:22:13'</Date>
<From>'Simon Bunzli'</From>
<Text>
<Sentence ID = "9.1"> (In reply to comment #7)</Sentence>
<Sentence ID = "9.2"> &gt; +1</Sentence>
<Sentence ID = "9.3"> That's bug 350731.</Sentence>
<Sentence ID = "9.4"> Care to convince mconnor that he's wrong? ;-)</Sentence>
</Text>
</Turn>
<Turn>
<Date>'2008-08-19 22:49:19'</Date>
<From>'Reed Loden'</From>
<Text>
<Sentence ID = "10.1"> Pushed as 17120:e712e96d7861 and 17121:adb1ef78dd21.</Sentence>
</Text>
</Turn>
<Turn>
<Date>'2008-08-20 02:15:09'</Date>
<From>'Simon Bunzli'</From>
<Text>
<Sentence ID = "11.1"> onemen: This patch significantly affects Tab Mix Plus:</Sentence>
<Sentence ID = "11.2"> Instead of disabling SessionStore, you'll now have to replace it by shipping a component which implements the same API.</Sentence>
<Sentence ID = "11.3"> You should be able to keep that component minimal, though, and just call your own code whenever the API is used.</Sentence>
<Sentence ID = "11.4"> This will make the lives of people using the SessionStore API (such as Session Manager) somewhat simpler, as they can just use the API without having to worry too much about the implementation behind it.</Sentence>
<Sentence ID = "11.5"> If you want to offer the option of switching between your and our implementation, see e.g. the ignore-history component of the Torbutton extension for how to overwrite a component with the original still being available internally (so that you can either pass API calls forward or handle them yourself).</Sentence>
</Text>
</Turn>
<Turn>
<Date>'2008-08-20 09:46:40'</Date>
<From>'Dave Townsend'</From>
<Text>
<Sentence ID = "12.1"> Sounds like this has impact for extension authors and so should be documented on MDC</Sentence>
</Text>
</Turn>
<Turn>
<Date>'2008-08-20 10:10:49'</Date>
<From>'onemen'</From>
<Text>
<Sentence ID = "13.1"> no problem.</Sentence>
<Sentence ID = "13.2"> current Tabmix dev-build already not disable SessionStore</Sentence>
<Sentence ID = "13.3"> I currently have only one problem , how to disable the restore after restart.</Sentence>
<Sentence ID = "13.4"> can you add a pref for this, or some other way to do it?</Sentence>
</Text>
</Turn>
<Turn>
<Date>'2008-08-20 11:04:03'</Date>
<From>'Simon Bunzli'</From>
<Text>
<Sentence ID = "14.1"> (In reply to comment #12)</Sentence>
<Sentence ID = "14.2"> &gt; I currently have only one problem , how to disable the restore after restart.</Sentence>
<Sentence ID = "14.3"> You've got several options for that:</Sentence>
<Sentence ID = "14.4"> * Set the prefs browser.sessionstore.resume_from_crash and browser.sessionstore.resume_session_once both to false as early as possible and make sure that browser.startup.page isn't 3.</Sentence>
<Sentence ID = "14.5"> * Delete the file sessionstore.js as early as possible (e.g. when the profile-after-change notification is dispatched).</Sentence>
<Sentence ID = "14.6"> * For Firefox 3.1: Respond to the sessionstore-state-read notification by setting the subject's data member to an empty string (cf. bug 448741 comment#6).</Sentence>
<Sentence ID = "14.7"> Or is there a use case I'm missing?</Sentence>
</Text>
</Turn>
</BugReport>
<BugReport ID = "3">
<Title>"(491925) Firefox - Disable multitouch \"rotate\" gesture for cycling tabs"</Title>
<Turn>
<Date>'2009-05-07 13:09:47'</Date>
<From>'Justin Dolske'</From>
<Text>
<Sentence ID = "1.1"> I've noticed that I frequently trigger the rotate gesture accidentally, usually while scrolling.</Sentence>
<Sentence ID = "1.2"> Gestures have improved since the original landing (when triggering the wrong gesture was really easy), but this articular gesture is still problematic.</Sentence>
<Sentence ID = "1.3"> The basic reasoning is that it's highly disruptive to be switched to another tab when you're not expecting it.</Sentence>
<Sentence ID = "1.4"> When it happens, you don't know what just happened until you notice that you're on some entirely different page, that's randomly to the left or right (1 or more tabs) from the page you thought you were on.</Sentence>
<Sentence ID = "1.5"> I'm don't think the rotate gesture for switching tabs is nearly as useful, discoverable, or a good fit as the other gestures are.</Sentence>
<Sentence ID = "1.6"> So, given this problem, we should just disable it for 3.5. </Sentence>
<Sentence ID = "1.7"> [I'd also be open to tweaking it to make it much harder to trigger accidentally, dunno if that's possible.]</Sentence>
</Text>
</Turn>
<Turn>
<Date>'2009-05-07 13:20:26'</Date>
<From>'Henrik Skupin'</From>
<Text>
<Sentence ID = "2.1"> See also bug 461376. </Sentence>
<Sentence ID = "2.2"> Just play around with browser.gesture.twist.* in about:config as a temporary workaround.</Sentence>
</Text>
</Turn>
<Turn>
<Date>'2009-05-07 14:11:45'</Date>
<From>'Mike Beltzner'</From>
<Text>
<Sentence ID = "3.1"> Justin, the odd thing here is that I find I trigger zoom more frequently than tab rotate ... far far more frequently.</Sentence>
<Sentence ID = "3.2"> And I also find that it's not just in Firefox, it's all over OSX.</Sentence>
<Sentence ID = "3.3"> I wonder how much of this is us vs. odd timings causing misreads of the trackpad by OSX.</Sentence>
</Text>
</Turn>
<Turn>
<Date>'2009-05-07 15:03:52'</Date>
<From>'Olli Pettay'</From>
<Text>
<Sentence ID = "4.1"> I think I've never accidentally switched tab because of rotate gesture.</Sentence>
<Sentence ID = "4.2"> Actually I'd probably decrease the default threshold for tab switching.</Sentence>
</Text>
</Turn>
<Turn>
<Date>'2009-05-07 16:02:51'</Date>
<From>'Justin Dolske'</From>
<Text>
<Sentence ID = "5.1"> I've triggered zoom repeatedly too; </Sentence>
<Sentence ID = "5.2"> usually I fix it right away but a quick browse though content-prefs.sqlite shows ~20 sites with zoom settings that I didn't know were set.</Sentence>
<Sentence ID = "5.3"> That's probably because zoom is a subtle effect (for 1 step, relative to the distraction that an accidental tab switch causes).</Sentence>
<Sentence ID = "5.4"> While playing with different browser.gesture.twist settings, I've found twisting through tabs often resulted in triggering a zoom. </Sentence>
<Sentence ID = "5.5"> Probably because a twist is a very awkward gesture to make, especially if it's more than a quarter-turn... </Sentence>
<Sentence ID = "5.6"> Around that point, my fingers want to spread or join, and that ends up read as a pinch. </Sentence>
<Sentence ID = "5.7"> I guess that's part of why I'm not really fond of this gesture, and would just as soon turn it off.</Sentence>
<Sentence ID = "5.8"> I'll try running with a threshold of 40, but I suspect there's an unavoidable conflict between making it easy to use on purpose, yet hard to invoke accidentally.</Sentence>
</Text>
</Turn>
<Turn>
<Date>'2009-05-07 16:08:28'</Date>
<From>'Edward Lee'</From>
<Text>
<Sentence ID = "6.1"> I've been using swipe left/right to change tabs and cmd-left/right to go back/forward, but I do have rotate as change tabs as well and I haven't accidentally triggered it.</Sentence>
<Sentence ID = "6.2"> Maybe it's your rotating technique ;) </Sentence>
<Sentence ID = "6.3"> I'm right handed and I position my index finger at 7oclock and ring finger at 1oclock. </Sentence>
<Sentence ID = "6.4"> To rotate right I end up at 8/2oclocks.</Sentence>
</Text>
</Turn>
<Turn>
<Date>'2009-05-07 16:10:08'</Date>
<From>'Samuel Sidler'</From>
<Text>
<Sentence ID = "7.1"> The first time I came into contact with tab switching via gesture was accidentally. </Sentence>
<Sentence ID = "7.2"> I wasn't sure what happened, I just appeared on another tab and couldn't figure out why. </Sentence>
<Sentence ID = "7.3"> The tab-switching gesture right now isn't obvious and feels unexpected when I hit it.</Sentence>
</Text>
</Turn>
<Turn>
<Date>'2009-05-11 07:00:44'</Date>
<From>'Mike Beltzner'</From>
<Text>
<Sentence ID = "8.1"> Mardak: the way you've written this code, disabling the gesture is a pref-flip, right?</Sentence>
<Sentence ID = "8.2"> Blocking here for decision and mulling, will probably take it though.</Sentence>
</Text>
</Turn>
<Turn>
<Date>'2009-05-11 08:38:06'</Date>
<From>'Edward Lee Mardak'</From>
<Text>
<Sentence ID = "9.1"> Yup, should be able to just unset the default value for the twist prefs:</Sentence>
<Sentence ID = "9.2"> -pref(\"browser.gesture.twist.right\", \"Browser:NextTab\");</Sentence>
<Sentence ID = "9.3"> -pref(\"browser.gesture.twist.left\", \"Browser:PrevTab\");</Sentence>
</Text>
</Turn>
<Turn>
<Date>'2009-05-11 10:45:51'</Date>
<From>'Justin Dolske'</From>
<Text>
<Sentence ID = "10.1"> Would setting the value to empty-string (\"\") work, or something similar? </Sentence>
<Sentence ID = "10.2"> It would be nice to leave the prefs visible for those who want to use them.</Sentence>
</Text>
</Turn>
<Turn>
<Date>'2009-05-11 12:24:05'</Date>
<From>'Robert Strong'</From>
<Text>
<Sentence ID = "11.1"> Since this is now implemented on Win7 with Multitouch screens please be sure not to disable it for Windows.</Sentence>
</Text>
</Turn>
<Turn>
<Date>'2009-05-11 14:54:42'</Date>
<From>'Justin Dolske'</From>
<Text>
<Sentence ID = "12.1"> (In reply to comment #10)</Sentence>
<Sentence ID = "12.2"> &gt; Since this is now implemented on Win7 with Multitouch screens please be sure not to disable it for Windows.</Sentence>
<Sentence ID = "12.3"> Fine by me; though I'd be a bit wary of having Windows users hit the same problem with multitouch trackpads...</Sentence>
<Sentence ID = "12.4"> But Rob says such hardware/drivers doesn't exist today, so it shouldn't be a common problem.</Sentence>
<Sentence ID = "12.5"> We should keep on eye out for problems with issues on touchscreens, andt from Rob demoing it on his touchscreen it would appear harder to trigger. </Sentence>
<Sentence ID = "12.6"> And maybe Windows 7 is just better at discriminating between gestures.</Sentence>
<Sentence ID = "12.7"> OTOH it wouldn't be a big deal to just disable it globally. </Sentence>
<Sentence ID = "12.8"> Safari doesn't use it, and Rob confirmed that IE doesn't use it on Windows 7.</Sentence>
</Text>
</Turn>
<Turn>
<Date>'2009-05-11 15:00:31'</Date>
<From>'Edward Lee Mardak'</From>
<Text>
<Sentence ID = "13.1"> This bug is just rotate, but do we want to consider pinching too?</Sentence>
<Sentence ID = "13.2"> If we take those out, we'll have swipe up/down as jump to top/bottom and swipe left/right as back/forward by default.</Sentence>
</Text>
</Turn>
<Turn>
<Date>'2009-05-11 15:24:24'</Date>
<From>'Justin Dolske'</From>
<Text>
<Sentence ID = "14.1"> (In reply to comment #12)</Sentence>
<Sentence ID = "14.2"> &gt; This bug is just rotate, but do we want to consider pinching too?</Sentence>
<Sentence ID = "14.3"> Maybe; it certainly has been noted that people are accidentally hitting that gesture too. </Sentence>
<Sentence ID = "14.4"> Though I think it's a separate decision: rotate is an unnatural gesture for switching tabs (nothing else uses it this way), with a high penalty for accidentally triggering. </Sentence>
<Sentence ID = "14.5"> Pinching is a natural gesture for page zoom (and more widely used/known), with a low penalty for accidentally triggering. </Sentence>
<Sentence ID = "14.6"> I think most people would consider it a bug if we claimed to support multitouch, but pinch didn't do anything.</Sentence>
<Sentence ID = "14.7"> So, I'd strongly lean towards only removing the rotate. Pinchy would've wanted it this way.</Sentence>
</Text>
</Turn>
<Turn>
<Date>'2009-05-11 15:32:51'</Date>
<From>'Jim Mathies'</From>
<Text>
<Sentence ID = "15.1"> (In reply to comment #12)</Sentence>
<Sentence ID = "15.2"> &gt; This bug is just rotate, but do we want to consider pinching too?</Sentence>
<Sentence ID = "15.3"> &gt; </Sentence>
<Sentence ID = "15.4"> &gt; If we take those out, we'll have swipe up/down as jump to top/bottom and swipe left/right as back/forward by default.</Sentence>
<Sentence ID = "15.5"> pinch should definitely be left on for win7.</Sentence>
<Sentence ID = "15.6"> Tracking is turned off so you get a nice zoom in/zoom out effect. </Sentence>
<Sentence ID = "15.7"> It's also nearly impossible to trigger without a definitive pinch with two fingers on the screen.</Sentence>
</Text>
</Turn>
<Turn>
<Date>'2009-05-11 20:48:28'</Date>
<From>'Mike Beltzner'</From>
<Text>
<Sentence ID = "16.1"> If you want to consider disabling pinch, please file a separate bug, do not conflate. </Sentence>
<Sentence ID = "16.2"> FWIW, I'm not nearly as keen on disabling that one, and am fairly-to-surely likely to WONTFIX such a bug.</Sentence>
<Sentence ID = "16.3"> But go ahead ... try me ;) </Sentence>
</Text>
</Turn>
<Turn>
<Date>'2009-05-11 21:29:39'</Date>
<From>'Edward Lee Mardak'</From>
<Text>
<Sentence ID = "17.1"> Created an attachment (id=376850) [details]</Sentence>
<Sentence ID = "17.2"> v1</Sentence>
<Sentence ID = "17.3"> Don't do anything on os x when twisting.</Sentence>
<Sentence ID = "17.4"> Alternatively, have people tried upping the threshold for twist? </Sentence>
<Sentence ID = "17.5"> It would make it less likely to accidentally trigger.</Sentence>
<Sentence ID = "17.6"> But I just noticed something interesting in os x's gesture detection.</Sentence>
<Sentence ID = "17.7"> - If I use 2 hands (1 finger each) and place one at the top and one at the bottom, moving the top finger registers as a normal mouse move while moving the bottom finger is registered as a twist.</Sentence>
<Sentence ID = "17.8"> I suppose the heuristic there is to assume the top finger is used for scrolling.</Sentence>
<Sentence ID = "17.9"> - Also, if your fingers are too close to the edge, it won't treat it as a rotate. But you can still move the pointer from the edge.</Sentence>
</Text>
</Turn>
<Turn>
<Date>'2009-05-19 13:37:50'</Date>
<From>'Mike Beltzner'</From>
<Text>
<Sentence ID = "18.1"> Can we get the patch reviewed - I think we want to remove the rotate gesture on both Windows and OSX.</Sentence>
</Text>
</Turn>
<Turn>
<Date>'2009-05-19 13:47:53'</Date>
<From>'Edward Lee Mardak'</From>
<Text>
<Sentence ID = "19.1"> Created an attachment (id=378424) [details]</Sentence>
<Sentence ID = "19.2"> v2</Sentence>
<Sentence ID = "19.3"> both Windows and OSX.</Sentence>
</Text>
</Turn>
<Turn>
<Date>'2009-05-19 23:14:15'</Date>
<From>'Mike Beltzner'</From>
<Text>
<Sentence ID = "20.1"> (From update of attachment 378424 [details])</Sentence>
<Sentence ID = "20.2"> uir+r=beltzner</Sentence>
</Text>
</Turn>
<Turn>
<Date>'2009-05-19 23:57:31'</Date>
<From>'Edward Lee Mardak'</From>
<Text>
<Sentence ID = "21.1"> http://hg.mozilla.org/mozilla-central/rev/d19424342b43</Sentence>
<Sentence ID = "21.2"> Give empty commands for twist gestures, so they do nothing, but still show up as prefs in about:config.</Sentence>
</Text>
</Turn>
<Turn>
<Date>'2009-05-20 16:44:33'</Date>
<From>'Edward Lee Mardak'</From>
<Text>
<Sentence ID = "22.1"> http://hg.mozilla.org/releases/mozilla-1.9.1/rev/3329a3997d7b</Sentence>
</Text>
</Turn>
<Turn>
<Date>'2009-05-26 07:58:47'</Date>
<From>'Henrik Skupin'</From>
<Text>
<Sentence ID = "23.1"> Verified fixed on trunk and 1.9.1 with builds on OS X and Windows like:</Sentence>
<Sentence ID = "23.2"> Mozilla/5.0 (Macintosh; U; Intel Mac OS X 10.5; en-US; rv:1.9.2a1pre) Gecko/20090525 Minefield/3.6a1pre ID:20090525031110</Sentence>
<Sentence ID = "23.3"> Mozilla/5.0 (Macintosh; U; Intel Mac OS X 10.5; en-US; rv:1.9.1pre) Gecko/20090526 Shiretoko/3.5pre ID:20090526031155</Sentence>
</Text>
</Turn>
<Turn>
<Date>'2009-07-05 13:49:55'</Date>
<From>'Nick Lowe'</From>
<Text>
<Sentence ID = "24.1"> Off the back of this, would there be any chance of getting...</Sentence>
<Sentence ID = "24.2"> browser.gesture.swipe.left.shift added and set to Browser:PrevTab</Sentence>
<Sentence ID = "24.3"> and</Sentence>
<Sentence ID = "24.4"> browser.gesture.swipe.right.shift added and set to Browser:NextTab</Sentence>
<Sentence ID = "24.5"> Having made this change, I must admit to now finding Firefox almost 'alien' to use on other multi-touch machines!</Sentence>
</Text>
</Turn>
<Turn>
<Date>'2009-07-05 16:12:40'</Date>
<From>'Nick Lowe'</From>
<Text>
<Sentence ID = "25.1"> https://bugzilla.mozilla.org/show_bug.cgi?id=502500</Sentence>
</Text>
</Turn>
</BugReport>
<BugReport ID = "4">
<Title>"(250125) Eclipse - createExistentResourceFromHandle forgets to create children resources"</Title>
<Turn>
<Date>'2008-10-08 12:51:00'</Date>
<From>'Kai Klesatschke'</From>
<Text>
<Sentence ID = "1.1"> Problem:</Sentence>
<Sentence ID = "1.2"> The method FolderDescription#createExistentResourceFromHandle(IResource,IProgressMonitor) checks if the folder already exists and returns immediately if so.</Sentence>
<Sentence ID = "1.3"> In cases where the FolderDescription has members which are not existing at that moment, that members will not be created.</Sentence>
<Sentence ID = "1.4"> Use case:</Sentence>
<Sentence ID = "1.5"> Assume you want to create a folder and a file in that folder and use two operations for this. </Sentence>
<Sentence ID = "1.6"> I know it is not necessary to use two operations but my configuration is more complex than this example code.</Sentence>
<Sentence ID = "1.7"> IFolder folder = ... // must not exist</Sentence>
<Sentence ID = "1.8"> CreateFolderOperation op1 = new CreateFolderOperation(folder,...);</Sentence>
<Sentence ID = "1.9"> IFile file = folder.getFile(...); // must not exist</Sentence>
<Sentence ID = "1.10"> CreateFileOperation op1 = new CreateFileOperation(file,...);</Sentence>
<Sentence ID = "1.11"> op1.execute(...);</Sentence>
<Sentence ID = "1.12"> op2.execute(...);</Sentence>
<Sentence ID = "1.13"> The execution of the op2 does not create the file because as stated above createExistentResourceFromHandle returns immediately because the parent folder of the file was created by op1.</Sentence>
<Sentence ID = "1.14"> IMHO createExistentResourceFromHandle must check if members of a FolderDescription should be created.</Sentence>
</Text>
</Turn>
<Turn>
<Date>'2008-10-08 12:57:20'</Date>
<From>'Kai Klesatschke'</From>
<Text>
<Sentence ID = "2.1"> I checked the code in the ganymede release and the problem should exist there too.</Sentence>
</Text>
</Turn>
<Turn>
<Date>'2008-10-22 13:01:23'</Date>
<From>'Susan F. McCourt'</From>
<Text>
<Sentence ID = "3.1"> Is there any reason you cannot execute op1 before creating op2?</Sentence>
<Sentence ID = "3.2"> The basic problem is that the workspace file structure has changed since you first created the operation, so the change described by the operation is no longer valid.</Sentence>
</Text>
</Turn>
<Turn>
<Date>'2008-10-23 03:05:42'</Date>
<From>'Kai Klesatschke'</From>
<Text>
<Sentence ID = "4.1"> &gt;Is there any reason you cannot execute op1 before creating op2?</Sentence>
<Sentence ID = "4.2"> No there is not.</Sentence>
<Sentence ID = "4.3"> In the meantime I found a workaround in my code but I think it's very inconvenient that someone must know that op2 have to be created after the execution of op1. </Sentence>
<Sentence ID = "4.4"> The API gave me no hint that I have to do so!</Sentence>
<Sentence ID = "4.5"> Maybe the build of the FolderDescription could be delayed until the execution of op2.</Sentence>
<Sentence ID = "4.6"> Think about cases where the to ops have nothing in common e.g. created and executed in different plug-ins.</Sentence>
</Text>
</Turn>
<Turn>
<Date>'2008-10-23 11:12:00'</Date>
<From>'Susan F. McCourt'</From>
<Text>
<Sentence ID = "5.1"> I'll mark this one for M4.</Sentence>
<Sentence ID = "5.2"> I think what needs to happen is that the javadoc better describes the lifecycle of these operations, and the isValid() method is tightened up so that the operation becomes invalid when the workspace changes to no longer match its recorded state. </Sentence>
<Sentence ID = "5.3"> It is not the intention of these classes to stay in synch with workspace changes that happen independently of a shared, sequential workspace history.</Sentence>
</Text>
</Turn>
<Turn>
<Date>'2009-01-30 03:35:08'</Date>
<From>'Dani Megert'</From>
<Text>
<Sentence ID = "6.1"> Moving target as M6 has shipped.</Sentence>
</Text>
</Turn>
<Turn>
<Date>'2009-04-16 15:30:37'</Date>
<From>'Susan F. McCourt'</From>
<Text>
<Sentence ID = "7.1"> Fixed in HEAD &gt;20090416.</Sentence>
<Sentence ID = "7.2"> In order to understand better what the ramifications might be of actually fixing this bug vs. better documenting the limitations and usage, I started by implementing a trial fix for the problem as reported.</Sentence>
<Sentence ID = "7.3"> It is pretty straightforward to rearrange the code to create the child resources (the file) even if the parent exists since the operation was created.</Sentence>
<Sentence ID = "7.4"> However, the problems occur later when you try to undo such an operation. </Sentence>
<Sentence ID = "7.5"> Since the operation \"remembered\" that the folder didn't exist when it was first created, the undo of the create file operation tries to also delete the folder. </Sentence>
<Sentence ID = "7.6"> This means that to truly fix the bug, we'd have to change the operations so that the resource descriptions were constantly updated to deal with changes that occurred.</Sentence>
<Sentence ID = "7.7"> So I still believe it's better to document more clearly what the intentions of the API are. </Sentence>
<Sentence ID = "7.8"> I've updated the javadoc for AbstractResourcesOperation, CreateFileOperation, and CreateFolderOperation. </Sentence>
<Sentence ID = "7.9"> In addition, I created a stricter validity check on CreateFileOperation so that the operation will return an invalid status if portions of the resource tree already exist. </Sentence>
<Sentence ID = "7.10"> Created WorkspaceOperationsTest.test250125() to simulate this condition. </Sentence>
<Sentence ID = "7.11"> The CreateFileOperation is valid until the CreateFolderOperation is run, at which time the file operation knows it is invalid.</Sentence>
</Text>
</Turn>
<Turn>
<Date>'2009-04-16 15:34:13'</Date>
<From>'Susan F. McCourt'</From>
<Text>
<Sentence ID = "8.1"> &gt; In addition, I created a stricter validity check on CreateFileOperation so that the operation will return an invalid status if portions of the resource tree already exist. </Sentence>
<Sentence ID = "8.2"> What I meant to say is...</Sentence>
<Sentence ID = "8.3"> I created a stricter validity check on CreateFileOperation so that the operation will return an invalid status if portions of the resource tree *that did not exist when the operation was created* already exist at the time of execution. </Sentence>
<Sentence ID = "8.4"> It is expected/allowed that the containment tree already exists when the op is executed, as long they also existed when the op was created.</Sentence>
</Text>
</Turn>
<Turn>
<Date>'2009-04-28 16:31:24'</Date>
<From>'Susan F. McCourt'</From>
<Text>
<Sentence ID = "9.1"> verified via automated test cases that run on each build.</Sentence>
<Sentence ID = "9.2"> Also verified through source inspection</Sentence>
</Text>
</Turn>
</BugReport>
<BugReport ID = "5">
<Title>"(224588) Eclipse - [Patch] Provide an information how many lines does the patch change"</Title>
<Turn>
<Date>'2008-03-28 09:19:00'</Date>
<From>'Tomasz Zarna'</From>
<Text>
<Sentence ID = "1.1"> Inspired by Martin Oberhuber's mail about his \"lsc\" script for counting lines in a patch[1], I though that it maybe be worthwhile to embed such thing in the Apply Patch wizard itself. </Sentence>
<Sentence ID = "1.2"> imo using regexp should be enough here, especially due to the fact that we don't want to make any additional dependencies. </Sentence>
<Sentence ID = "1.3"> So, my proposal is to allow to specify a regexp rule for lines that should be count as a \"real contribution\".</Sentence>
<Sentence ID = "1.4"> This is what first came to my head:</Sentence>
<Sentence ID = "1.5"> /-\\\\+? (\\s*\\S+\\s*)+$</Sentence>
<Sentence ID = "1.6"> which means \"Count only lines starting with single '+' and a space. </Sentence>
<Sentence ID = "1.7"> The line must also have at least one non-whitespace character\". </Sentence>
<Sentence ID = "1.8"> I think this is more/less what Martin's script does.</Sentence>
<Sentence ID = "1.9"> All lines that match the above pattern would be sum up and the info would be displayed somewhere on the Apply Patch wizard. </Sentence>
<Sentence ID = "1.10"> How does it sound? Martin?</Sentence>
<Sentence ID = "1.11"> Again, I think it's a brilliant idea Martin.</Sentence>
<Sentence ID = "1.12"> [1] sent to eclipse.org-committers</Sentence>
</Text>
</Turn>
<Turn>
<Date>'2008-03-28 09:22:45'</Date>
<From>'Tomasz Zarna'</From>
<Text>
<Sentence ID = "2.1"> The info could be also shown in a patch outline view (see bug 190418).</Sentence>
</Text>
</Turn>
<Turn>
<Date>'2008-03-28 09:42:46'</Date>
<From>'Martin Oberhuber'</From>
<Text>
<Sentence ID = "3.1"> Excellent idea! </Sentence>
<Sentence ID = "3.2"> Having the line counter right in the apply patch wizard would finally give us a standard way of counting lines that everybody could use easily.</Sentence>
<Sentence ID = "3.3"> My script also ignores \"empty comment\" lines of the form</Sentence>
<Sentence ID = "3.4"> /-\\\\+\\s+[#*]+\\s+$</Sentence>
<Sentence ID = "3.5"> but that's really neglectible and I'm fine with your approach of counting any non-empty added line in the patch.</Sentence>
<Sentence ID = "3.6"> Actually, couldn't your regex even be simpler, say</Sentence>
<Sentence ID = "3.7"> /-\\\\+\\s+\\S</Sentence>
<Sentence ID = "3.8"> since you don't need to check till the end of the line?</Sentence>
</Text>
</Turn>
<Turn>
<Date>'2008-03-28 09:46:03'</Date>
<From>'Martin Oberhuber'</From>
<Text>
<Sentence ID = "4.1"> And actually, if the wizard counts added lines, why shouldn't it also count removed lines? </Sentence>
<Sentence ID = "4.2"> Giving two separate numbers e.g.</Sentence>
<Sentence ID = "4.3"> 10 lines added 20 lines removed</Sentence>
<Sentence ID = "4.4"> This sounds familiar to me since I've seen similar numbers in RCS files before.</Sentence>
<Sentence ID = "4.5"> I'd guess that the regex for removed lines could just be the same as for added lines but the + replaced by a -; and, files removed entirely should contribute the entire number of lines they had before (I believe that the old contents is</Sentence>
<Sentence ID = "4.6"> not recorded in the diff, is it?)</Sentence>
</Text>
</Turn>
<Turn>
<Date>'2008-04-01 09:32:36'</Date>
<From>'Tomasz Zarna'</From>
<Text>
<Sentence ID = "5.1"> Created an attachment (id=94358) [details]</Sentence>
<Sentence ID = "5.2"> Patch</Sentence>
<Sentence ID = "5.3"> Fix that matches all lines from a patch against given regexps (one for added lines and one for removed). </Sentence>
<Sentence ID = "5.4"> Patterns can be changed on General &gt; Compare/Patch pref page. </Sentence>
<Sentence ID = "5.5"> I decided to leave them blank by default, so I don't need to worry about different diff output formats which are out there. </Sentence>
<Sentence ID = "5.6"> However, you can easily set it to a value most convenient to you (i.e. '/-\\\\+\\s+\\S').</Sentence>
</Text>
</Turn>
<Turn>
<Date>'2008-04-01 09:32:39'</Date>
<From>'Tomasz Zarna'</From>
<Text>
<Sentence ID = "6.1"> Created an attachment (id=94360) [details]</Sentence>
<Sentence ID = "6.2"> mylyn/context/zip</Sentence>
</Text>
</Turn>
<Turn>
<Date>'2008-04-01 09:38:19'</Date>
<From>'Martin Oberhuber'</From>
<Text>
<Sentence ID = "7.1"> (In reply to comment #4)</Sentence>
<Sentence ID = "7.2"> &gt; I decided to leave them blank by default, so I don't need to worry</Sentence>
<Sentence ID = "7.3"> So this means it won't work out of the box? But then, the compare/patch feature already needs to analyze patches or it cannot apply them, right? </Sentence>
<Sentence ID = "7.4"> So I don't quite understand why the same patterns that compare/patch already uses aren't the default for the line counting feature.</Sentence>
</Text>
</Turn>
<Turn>
<Date>'2008-04-02 11:54:35'</Date>
<From>'Tomasz Zarna'</From>
<Text>
<Sentence ID = "8.1"> (In reply to comment #6)</Sentence>
<Sentence ID = "8.2"> &gt; So this means it won't work out of the box? </Sentence>
<Sentence ID = "8.3"> &gt; But then, the compare/patch feature already needs to analyze patches or it cannot apply them, right? </Sentence>
<Sentence ID = "8.4"> &gt; So I don't &gt; quite understand why the same patterns that compare/patch already uses aren't the default for the line counting feature.</Sentence>
<Sentence ID = "8.5"> I guess you're right Martin, but this will make the patch a little bit more complicated as the current patching mechanism is not very helpful in counting added/removed lines. </Sentence>
<Sentence ID = "8.6"> I'll just need some extra time to do this.</Sentence>
</Text>
</Turn>
<Turn>
<Date>'2008-04-21 09:11:06'</Date>
<From>'Tomasz Zarna'</From>
<Text>
<Sentence ID = "9.1"> Created an attachment (id=96838) [details]</Sentence>
<Sentence ID = "9.2"> Patch 2</Sentence>
</Text>
</Turn>
<Turn>
<Date>'2008-04-21 09:11:09'</Date>
<From>'Tomasz Zarna'</From>
<Text>
<Sentence ID = "10.1"> Created an attachment (id=96839) [details]</Sentence>
<Sentence ID = "10.2"> mylyn/context/zip</Sentence>
</Text>
</Turn>
<Turn>
<Date>'2008-04-21 09:29:15'</Date>
<From>'Tomasz Zarna'</From>
<Text>
<Sentence ID = "11.1"> The latest patch ensures, that when no regular expressions is provided, the patcher will use internal patterns to distinguish which lines have been added or deleted. </Sentence>
<Sentence ID = "11.2"> However, this will work only for patches in unified and context diff output format. </Sentence>
<Sentence ID = "11.3"> As reported in bug 227742, it appears that standard patch format is no longer supported (or it has never been).</Sentence>
<Sentence ID = "11.4"> Moreover, I logged bug 228000 to make sure we add some automated tests to cover this newly added feature.</Sentence>
</Text>
</Turn>
<Turn>
<Date>'2008-04-22 05:47:53'</Date>
<From>'Tomasz Zarna'</From>
<Text>
<Sentence ID = "12.1"> Created an attachment (id=96993) [details]</Sentence>
<Sentence ID = "12.2"> Patch 3</Sentence>
<Sentence ID = "12.3"> Previous patch with some minor adjustments.</Sentence>
</Text>
</Turn>
<Turn>
<Date>'2008-04-22 06:29:21'</Date>
<From>'Tomasz Zarna'</From>
<Text>
<Sentence ID = "13.1"> The latest patch applied to CVS HEAD. </Sentence>
<Sentence ID = "13.2"> Martin, would you like to try it out and let me know what do you think? </Sentence>
<Sentence ID = "13.3"> Feel free to open a new bug if there is something I missed.</Sentence>
</Text>
</Turn>
<Turn>
<Date>'2008-04-23 21:00:43'</Date>
<From>'Martin Oberhuber'</From>
<Text>
<Sentence ID = "14.1"> I tested this with I20080422-0800, on the attached patch from bug 227572 attachment 97084 [details]. </Sentence>
<Sentence ID = "14.2"> Your dialog counts 207 added and 29 removed lines, but my script only counts 151 added lines.</Sentence>
<Sentence ID = "14.3"> It looks like you are also counting empty lines, which doesn't seem overly useful to me.</Sentence>
</Text>
</Turn>
<Turn>
<Date>'2008-04-24 04:44:46'</Date>
<From>'Tomasz Zarna'</From>
<Text>
<Sentence ID = "15.1"> Created an attachment (id=97398) [details]</Sentence>
<Sentence ID = "15.2"> The preference page</Sentence>
<Sentence ID = "15.3"> The \"internal\" mechanism of counting added/removed lines is very simple, it sums up all lines with '+' and '-'. </Sentence>
<Sentence ID = "15.4"> If you want to use your own patterns/script please take a look at the General &gt; Compare/Patch pref page. </Sentence>
<Sentence ID = "15.5"> I've added there two fields where you can customize the way this simple mechanism works.</Sentence>
</Text>
</Turn>
<Turn>
<Date>'2008-04-24 07:09:41'</Date>
<From>'Martin Oberhuber'</From>
<Text>
<Sentence ID = "16.1"> It's awsome that this is customizeable, but when I remember right, one reason for putting this enhancement into Eclipse SDK was such that there is a \"common standard\" by which the projects count their lines in a patch.</Sentence>
<Sentence ID = "16.2"> I think that this \"common standard\" should be as good as possible by default.</Sentence>
<Sentence ID = "16.3"> On the other hand, having some magic like removing empty lines from the count going on in the background is perhaps a problem... </Sentence>
<Sentence ID = "16.4"> would it be possible to keep your current count (\"211 added / 53 removed lines\") but add an additional count without empty lines e.g.</Sentence>
<Sentence ID = "16.5"> Note that I'm only talking about empty lines here, e.g. Regex \"/-\\\\\\s*$\". </Sentence>
<Sentence ID = "16.6"> I agree that we cannot count empty comments here by default, because comment styles differ by language. </Sentence>
<Sentence ID = "16.7"> Actually, it might be a good idea to have one additional kind of Regex pattern in the Preferences, which acts as a filter -- suggested tooltip behind //:</Sentence>
<Sentence ID = "16.8"> Added Lines: /-\\+</Sentence>
<Sentence ID = "16.9"> Removed Lines: /-\\-</Sentence>
<Sentence ID = "16.10"> Filter: /-\\[+-]\\s*$ //Filter for lines to not count, e.g. empty lines</Sentence>
<Sentence ID = "16.11"> providing an output such as \"Patch contains 207 added and 29 removed lines (151 / 27 filtered)\"</Sentence>
</Text>
</Turn>
<Turn>
<Date>'2008-04-24 08:46:47'</Date>
<From>'Tomasz Zarna'</From>
<Text>
<Sentence ID = "17.1"> Martin, I see your point when you're saying that the \"common standard\" should be as good as possible, however I would rather not to filter any lines from a patch when parsing. Here are the approaches so far:</Sentence>
<Sentence ID = "17.2"> 1) Use only given filters, by default no counting will be made. </Sentence>
<Sentence ID = "17.3"> This is how the patch from comment 4 worked. </Sentence>
<Sentence ID = "17.4"> Rejected.</Sentence>
<Sentence ID = "17.5"> 2) By default count lines using the simple patterns, which are currently used when parsing a patch (ie \"+\" and \"-\"), this can be modified in the pref page.</Sentence>
<Sentence ID = "17.6"> Patch in comment 13. </Sentence>
<Sentence ID = "17.7"> In HEAD.</Sentence>
<Sentence ID = "17.8"> 3) By default count lines using more sophisticated patterns like excluding empty lines. </Sentence>
<Sentence ID = "17.9"> And again, this can be modified in the pref page. </Sentence>
<Sentence ID = "17.10"> If I understood you correctly this is what you meant in comment 15. </Sentence>
<Sentence ID = "17.11"> My main concern here is:</Sentence>
<Sentence ID = "17.12"> what if I would like to know total number of lines added in the patch (the filter idea looks to be an answer here but it's a pref value, it's not embedded in the parser itself, right?)</Sentence>
<Sentence ID = "17.13"> 4) By default count lines using both simple and sophisticated patterns at the same time. </Sentence>
<Sentence ID = "17.14"> The output would be something like this \"Patch contains X added and Y removed lines + Z added lines which are empty\". Again, the user could provide his own patterns... </Sentence>
<Sentence ID = "17.15"> which makes the whole mechanism overblown and not as intuitive as I would like it to be.</Sentence>
<Sentence ID = "17.16"> Regarding the filter idea: it sounds good to me, but I think we should move the discussion about it to a separate bug.</Sentence>
<Sentence ID = "17.17"> Would you mind opening one?</Sentence>
<Sentence ID = "17.18"> btw, thanks for your feedback Martin.</Sentence>
</Text>
</Turn>
<Turn>
<Date>'2008-04-30 08:53:01'</Date>
<From>'Tomasz Zarna'</From>
<Text>
<Sentence ID = "18.1"> Verified in I20080429-0100. </Sentence>
<Sentence ID = "18.2"> Martin are you willing to open new bugs to address your concerns?</Sentence>
</Text>
</Turn>
<Turn>
<Date>'2008-05-02 19:08:09'</Date>
<From>'Martin Oberhuber'</From>
<Text>
<Sentence ID = "19.1"> FYI,</Sentence>
<Sentence ID = "19.2"> following regex suppresses lines in the patch from counting, which are empty or only contain non-wordchars (i.e. lines which only contain an } or only contain a * as continuation of an empty Javadoc comment:</Sentence>
<Sentence ID = "19.3"> Added: /-\\\\+[/-\\+]+[a-zA-Z0-9_!?\"|@~`$%&()+;,.:&lt;&gt;=+-]</Sentence>
<Sentence ID = "19.4"> Removed: /-\\-[/-\\-]+[a-zA-Z0-9_!?\"|@~`$%&()+;,.:&lt;&gt;=+-]</Sentence>
</Text>
</Turn>
</BugReport>
<BugReport ID = "6">
<Title>"(223734) Eclipse - Incorrect deprecation comments in Platform class"</Title>
<Turn>
<Date>'2008-03-24 17:36:00'</Date>
<From>'Angel Vera'</From>
<Text>
<Sentence ID = "1.1"> According to the javaDoc in Platform.getResourceString(Bundle,String), this method has been deprecated and one should use the NLS class or the BundleFinder.find(). </Sentence>
<Sentence ID = "1.2"> I was able to find the NLS class but I didn't find the BundleFinder class. </Sentence>
<Sentence ID = "1.3"> Is the javaDoc correct? </Sentence>
<Sentence ID = "1.4"> if it is a hint on where to find the BundleFinder class would help.</Sentence>
<Sentence ID = "1.5"> The NLS class doesn't seem to provide me with the same functionality that Platform.getResourceString does, so I am assuming that BundleFinder would do the job that I need.</Sentence>
<Sentence ID = "1.6"> Please provide me with more information on where to find the BundleFinder and improve the javaDoc.</Sentence>
</Text>
</Turn>
<Turn>
<Date>'2008-03-25 09:57:01'</Date>
<From>'Oleg Besedin'</From>
<Text>
<Sentence ID = "2.1"> I don't think that replacement functionality was ever implemented.</Sentence>
<Sentence ID = "2.2"> Pascal, you added bunch of comments like that to the Platform ver. 1.92. </Sentence>
<Sentence ID = "2.3"> As there are no current plans to act on them (and there has been no actions done in the last 2 years) I think we need to remove those comments - they make a rather confusing Javadoc.</Sentence>
<Sentence ID = "2.4"> There are 21 \"XXX\" comments that should be removed from Javadoc or acted upon.</Sentence>
</Text>
</Turn>
<Turn>
<Date>'2008-03-25 09:59:06'</Date>
<From>'Oleg Besedin'</From>
<Text>
<Sentence ID = "3.1"> Adding M7 as a milestone to remind to remove those comments.</Sentence>
</Text>
</Turn>
<Turn>
<Date>'2008-03-25 11:55:35'</Date>
<From>'Angel Vera'</From>
<Text>
<Sentence ID = "4.1"> (In reply to comment #1)</Sentence>
<Sentence ID = "4.2"> &gt; I don't think that replacement functionality was ever implemented. </Sentence>
<Sentence ID = "4.3"> &gt; Pascal, you added bunch of comments like that to the Platform ver. 1.92. </Sentence>
<Sentence ID = "4.4"> &gt; As there are no current plans to act on them (and there has been no actions done &gt; in the last 2 years) I think we need to remove those comments - they make a rather confusing Javadoc.</Sentence>
<Sentence ID = "4.5"> &gt; There are 21 \"XXX\" comments that should be removed from Javadoc or acted upon.</Sentence>
<Sentence ID = "4.6"> </Sentence>
<Sentence ID = "4.7"> So are you saying that the support for using getResourceString has just been droppped, and that no replacement will be available? </Sentence>
<Sentence ID = "4.8"> that concerns me because WTP has a code that uses this method, and I am sure that there is plenty of adopters that are currently using that function as well.</Sentence>
</Text>
</Turn>
<Turn>
<Date>'2008-03-25 13:27:23'</Date>
<From>'Oleg Besedin'</From>
<Text>
<Sentence ID = "5.1"> The method Platform.getResourceString(Bundle,String) is not deprecated at this time; </Sentence>
<Sentence ID = "5.2"> the comments should have been added to the implementation code or to a bug report, not to the Javadoc of the Platform class. </Sentence>
</Text>
</Turn>
<Turn>
<Date>'2008-05-23 04:29:23'</Date>
<From>'Philippe Mulet'</From>
<Text>
<Sentence ID = "6.1"> Please adjust the target milestone, so it does not point at a closed milestone in the past.</Sentence>
</Text>
</Turn>
<Turn>
<Date>'2008-09-24 16:17:37'</Date>
<From>'Oleg Besedin'</From>
<Text>
<Sentence ID = "7.1"> From bug 247983 other tagged methods:</Sentence>
<Sentence ID = "7.2"> -getResourceBundle(Bundle)</Sentence>
<Sentence ID = "7.3"> -getResourceString(Bundle, String)</Sentence>
<Sentence ID = "7.4"> -getResourceString(Bundle, String, ResourceBundle)</Sentence>
</Text>
</Turn>
<Turn>
<Date>'2008-09-24 16:18:04'</Date>
<From>'Oleg Besedin'</From>
<Text>
<Sentence ID = "8.1"> *** Bug 247983 has been marked as a duplicate of this bug. ***</Sentence>
</Text>
</Turn>
<Turn>
<Date>'2008-09-24 16:42:07'</Date>
<From>'Oleg Besedin'</From>
<Text>
<Sentence ID = "9.1"> Removed incorrect comments from the Platform class.</Sentence>
</Text>
</Turn>
<Turn>
<Date>'2008-09-24 16:49:49'</Date>
<From>'John Arthome'</From>
<Text>
<Sentence ID = "10.1"> We collided, I just made the same changes. </Sentence>
<Sentence ID = "10.2"> The only difference is that I moved the comments to InternalPlatform. </Sentence>
<Sentence ID = "10.3"> Also I deprecated Platform#endSplash since this has been replaced with IApplicationContext#applicationRunning().</Sentence>
</Text>
</Turn>
</BugReport>
<BugReport ID = "7">
<Title>"(437797) Firefox - about:mozilla page is hardcoded to LTR in RC2"</Title>
<Turn>
<Date>'2008-06-07 10:59:00'</Date>
<From>'Tsahi Asher'</From>
<Text>
<Sentence ID = "1.1"> the about:mozilla page in RC2 is right-aligned, but has LTR directionality instead of RTL. </Sentence>
<Sentence ID = "1.2"> as a result, the dot at the end of the sentence is on the right side instead of the left, and both the parentheses around the \"10th edition\" line are on the right side.</Sentence>
<Sentence ID = "1.3"> i also think the quote source should be on the left side. </Sentence>
<Sentence ID = "1.4"> perhaps the page should take CSS from intl.css, where localisers can override some of the classes or add a class to set direction.</Sentence>
</Text>
</Turn>
<Turn>
<Date>'2008-06-07 11:12:04'</Date>
<From>'Tomer Cohen'</From>
<Text>
<Sentence ID = "2.1"> Actually I would like not to add yet another entry in intl.css but to fix it in aboutMozilla.xhtml. </Sentence>
<Sentence ID = "2.2"> Pike, can we think about it? </Sentence>
</Text>
</Turn>
<Turn>
<Date>'2008-06-07 11:23:41'</Date>
<From>'Tomer Cohen'</From>
<Text>
<Sentence ID = "3.1"> Same behavior also affect other internal about pages.</Sentence>
<Sentence ID = "3.2"> * about:plugins</Sentence>
<Sentence ID = "3.3"> pages that get RTL:</Sentence>
<Sentence ID = "3.4"> * about:crashes</Sentence>
<Sentence ID = "3.5"> * about:robots - Has some open issues. See bug 427029</Sentence>
<Sentence ID = "3.6"> Pages that not translated, such as about:cache, about:credits and about:buildconfig should stay LTR.</Sentence>
</Text>
</Turn>
<Turn>
<Date>'2008-06-07 12:19:57'</Date>
<From>'Tsahi Asher'</From>
<Text>
<Sentence ID = "4.1"> the about:mozilla page used to be a file in the language pack, allowing the localizer to control it's look. </Sentence>
<Sentence ID = "4.2"> moving this out of the language pack created this problem.</Sentence>
</Text>
</Turn>