Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Write effective tests that check for webhook calls #5

Open
leemcd56 opened this issue Oct 11, 2021 · 2 comments
Open

Write effective tests that check for webhook calls #5

leemcd56 opened this issue Oct 11, 2021 · 2 comments
Labels
bug Something isn't working enhancement New feature or request

Comments

@leemcd56
Copy link
Member

Is your feature request related to a problem? Please describe.
Before deploying, each endpoint needs to be thoroughly tested.

Describe the solution you'd like
Add feature tests for /webhook, and unit tests for Event and Dispatcher classes.
@leemcd56 leemcd56 added enhancement New feature or request bug Something isn't working labels Oct 11, 2021
@leemcd56
Copy link
Member Author

Following up on this, there is a test I wrote to check if /webhook was correctly dispatching events but I was getting an HTTP 500 response from supertest.

@leemcd56
Copy link
Member Author

@LeWestopher when you get the chance, can you look into what's causing these issues?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@leemcd56