-
Notifications
You must be signed in to change notification settings - Fork 130
Open
Labels
area/installIssues related to `bootc install`Issues related to `bootc install`area/selinuxRelates to SELinuxRelates to SELinuxtriagedThis looks like a valid issueThis looks like a valid issue
Description
Spawned from #1198 (comment)
I think in order to add a bit more crash resilence here it'd be a good idea to do e.g.:
rustix::fs::fsync(root.as_fd());
root.create(LABELED)?;
rustix::fs::fsync(root.as_fd());
or so - that should help ensure that we don't end up in a situation where (on a system crash) the LABELED file exists but the pending writes to do the relabeling didn't land.
(arg, in a quick test this fails because a cap-std Dir is an O_PATH fd and we can't fsync on that, I will look at a little helper for this)
Metadata
Metadata
Assignees
Labels
area/installIssues related to `bootc install`Issues related to `bootc install`area/selinuxRelates to SELinuxRelates to SELinuxtriagedThis looks like a valid issueThis looks like a valid issue