Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Macors are not parsed correctly and index is broken in Linux kernel tree (PINCTRL_PINGROUP, PINCTRL_PINFUNCTION) #241

Closed
andy-shev opened this issue Mar 21, 2023 · 4 comments
Labels
indexing Related to the index content — missing definitions/references, lexer bugs, new ctags features...

Comments

@andy-shev
Copy link

andy-shev commented Mar 21, 2023

The Elixir against Linux kernel source code misses the PINCTRL_PINGROUP() and PINCTRL_PINFUNCTION() macros users in the index, e.g. pinctrl-intel.h: https://elixir.bootlin.com/linux/v6.3-rc3/C/ident/PINCTRL_PINFUNCTION, while https://elixir.bootlin.com/linux/v6.3-rc3/source/drivers/pinctrl/intel/pinctrl-intel.h#L184.

@andy-shev
Copy link
Author

For v6.4-rc1 it's even worse. :-(

@fstachura fstachura added the indexing Related to the index content — missing definitions/references, lexer bugs, new ctags features... label Feb 21, 2025
@fstachura
Copy link
Collaborator

Is this still a problem? I compared results from mentioned tags and v6.14-rc3 with grep and the results look okay

@fstachura fstachura changed the title Macors are not parsed correctly and index is broken in Linux kernel tree Macors are not parsed correctly and index is broken in Linux kernel tree (PINCTRL_PINGROUP, PINCTRL_PINFUNCTION) Feb 21, 2025
@andy-shev
Copy link
Author

andy-shev commented Feb 23, 2025

LGTM now, any pointers to the commit, etc that fixed it?
Thanks for fixing, btw!

@fstachura
Copy link
Collaborator

Honestly, I'm not really sure. I remember thinking it was fixed the last time I was triaging bugs, but wanted to investigate. It looks like the default ctags on both Debian 11 and 12 recognizes this macro. I would guess it was the database corruption from around that time #246

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
indexing Related to the index content — missing definitions/references, lexer bugs, new ctags features...
Projects
None yet
Development

No branches or pull requests

2 participants