update code

Author: congminh1254

boxsdk/client/client.py

@@ -2043,8 +2043,6 @@ def get_authentication(self, *, token_storage=None):
             Authentication object compatible with the generated SDK (box_sdk_gen).
         :raises ValueError:
             If the authentication type is not supported or required credentials are missing.
-        :raises ValueError:
-            If the authentication type is not supported or required credentials are missing.
         """
         oauth = self._oauth
 
@@ -2207,7 +2205,6 @@ def get_network_session(
         network_client=None,
         retry_strategy=None,
         data_sanitizer=None,
-        interceptors=None,
         additional_headers=None,
     ):
         """
@@ -2222,8 +2219,6 @@ def get_network_session(
             If not provided, one will be created from legacy retry settings.
         :param data_sanitizer:
             Optional DataSanitizer instance for the generated SDK.
-        :param interceptors:
-            Optional list of request/response interceptors.
         :param additional_headers:
             Optional dictionary of additional HTTP headers to merge with legacy headers.
         :return:
@@ -2275,9 +2270,14 @@ def get_network_session(
             if hasattr(proxy_config, 'AUTH') and proxy_config.AUTH:
                 auth = proxy_config.AUTH
                 if isinstance(auth, dict) and 'user' in auth and 'password' in auth:
+                    scheme = (
+                        proxy_url.split('://', 1)[0] if '://' in proxy_url else 'http'
+                    )
                     # Extract host from URL
                     host = proxy_url.split('//')[1] if '//' in proxy_url else proxy_url
-                    proxy_url = f"http://{auth['user']}:{auth['password']}@{host}"
+                    proxy_url = (
+                        f"{scheme}://{auth['user']}:{auth['password']}@{host}"
+                    )
 
         # Merge custom headers
         headers = {}
@@ -2314,7 +2314,6 @@ def get_sdk_gen_client(self, *, auth_options=None, network_options=None):
             - network_client: Custom NetworkClient instance
             - retry_strategy: Custom RetryStrategy instance
             - data_sanitizer: Custom DataSanitizer instance
-            - interceptors: List of request/response interceptors
             - additional_headers: Dictionary of additional HTTP headers
         :return:
             BoxClient instance from box_sdk_gen, fully configured with shared settings.
@@ -2333,7 +2332,6 @@ def get_sdk_gen_client(self, *, auth_options=None, network_options=None):
                 'network_client': network_options.get('network_client'),
                 'retry_strategy': network_options.get('retry_strategy'),
                 'data_sanitizer': network_options.get('data_sanitizer'),
-                'interceptors': network_options.get('interceptors'),
                 'additional_headers': network_options.get('additional_headers'),
             }
 

docs/config-sharing-implementation.md

@@ -58,7 +58,6 @@ Extracts network configuration from the legacy client and converts it to a gener
 - `network_client` (optional): Custom `NetworkClient` instance
 - `retry_strategy` (optional): Custom `RetryStrategy` instance
 - `data_sanitizer` (optional): Custom `DataSanitizer` instance
-- `interceptors` (optional): List of request/response interceptors
 - `additional_headers` (optional): Dictionary of additional HTTP headers
 
 **Returns:**
@@ -88,7 +87,6 @@ Creates a fully configured generated SDK client from the legacy client. This is
   - `network_client`: Custom `NetworkClient` instance
   - `retry_strategy`: Custom `RetryStrategy` instance
   - `data_sanitizer`: Custom `DataSanitizer` instance
-  - `interceptors`: List of request/response interceptors
   - `additional_headers`: Dictionary of additional HTTP headers
 
 **Returns:**
@@ -250,10 +248,9 @@ Network settings are extracted from:
 
 ## Error Handling
 
-The implementation includes comprehensive error handling:
+The implementation raises:
 
-- `ValueError`: Raised for unsupported auth types or missing credentials
-- `TypeError`: Raised for invalid parameter types
+- `ValueError`: for unsupported auth types or missing credentials
 
 Note: Since `boxsdk` and `box_sdk_gen` are always installed together, import errors for `box_sdk_gen` should not occur in practice.
 

test/boxsdk/unit/client/test_config_sharing.py

@@ -4,10 +4,7 @@
 Tests get_authentication(), get_network_session(), and get_sdk_gen_client() methods.
 """
 
-from unittest.mock import Mock, MagicMock, patch
-import pytest
-
-from unittest.mock import Mock, MagicMock, patch
+from unittest.mock import Mock
 import pytest
 
 from boxsdk.client import Client