-
Notifications
You must be signed in to change notification settings - Fork 264
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Standardization of the order of the fields for the builders in all the templates #221
Comments
PR #220 currently re-organizes the ssh_username and ssh_password fields so they're anchored near the end between I don't plan on standardizing/documenting this other than maybe ensuring that the builders begin with their type and keeping cpus/cores/memory/etc. anchored near the vm_name since those shouldn't really change due to being controlled by user-variables. |
Commit 8474772 re-orders the floppy_files field in all the builders by prefixing them with their respective Autounattend.xml script, and sorting the rest by name. This greatly simplifies comparison to distinguish what is different between all the templates. Ftr, this was done with the following
|
The "iso_checksum_type" which was formerly hardcoded to "sha1" is now a user-variable as per PR #236. This also positions the "iso_checksum_type" right below the "iso_url" in all the builders. |
The |
The order of the fields in the builders for some of the templates are somewhat haphazard. This is just the natural order of things as the schema changes over time.
This isn't really too big of a deal, but if more than 1 person submits a PR that tampers with all of the templates (which could be common), PRs will look a lot larger than they should to git/patch and so the submitter will be forced to re-base a lot more often.
This also affects users that apply their own patches to arbitrary commits in the repo because in some cases
patch
in fuzzy-mode has nothing to consistently anchor upon.The text was updated successfully, but these errors were encountered: