From 81fffaba798b3a0c56f16f4bae2c8954c686fc0a Mon Sep 17 00:00:00 2001 From: Giannis Date: Fri, 30 Oct 2026 22:26:43 +0200 Subject: [PATCH] test(agc): name the missing mesh shader when the mesh vector window test skips The test returned 77 without a word on a device without VK_EXT_mesh_shader, so tools/check_skips.py could not tell an expected skip from lost coverage. Split the gate as the other mesh tests do and print the device reason. Co-Authored-By: Claude Opus 5.5 --- .../tests/execution/MeshVectorWindowWaves.cpp | 6 +++++- 1 file changed, 5 insertions(+), 1 deletion(-) diff --git a/core/libs/prx/libSceAgcDriver/tests/execution/MeshVectorWindowWaves.cpp b/core/libs/prx/libSceAgcDriver/tests/execution/MeshVectorWindowWaves.cpp index 4df1d3e86e1..4833c5a03b4 100644 --- a/core/libs/prx/libSceAgcDriver/tests/execution/MeshVectorWindowWaves.cpp +++ b/core/libs/prx/libSceAgcDriver/tests/execution/MeshVectorWindowWaves.cpp @@ -153,7 +153,11 @@ int main() { try { { const auto device = OpenVulkanTestDevice(); - if (!device || !TargetHasCapability(device->Target(), spv::CapabilityMeshShadingEXT)) return VulkanTestSkipped; + if (!device) return VulkanTestSkipped; + if (!TargetHasCapability(device->Target(), spv::CapabilityMeshShadingEXT)) { + std::puts("skipped, the device has no VK_EXT_mesh_shader"); + return VulkanTestSkipped; + } if (device->DeviceName().starts_with("llvmpipe")) { std::puts("skipped, the device has no mesh shader compiler that handles these programs (llvmpipe)"); return VulkanTestSkipped;