From fa889c063b3b4e64b96171d8cb700f5d8206b058 Mon Sep 17 00:00:00 2001 From: LeandroLP23 Date: Mon, 12 Oct 2026 14:19:45 +0200 Subject: [PATCH] docs(contributing): ask GPU changes to name the GPUs their tests ran on Co-Authored-By: Claude Opus 5.5 --- .github/pull_request_template.md | 1 + CONTRIBUTING.md | 1 + 2 files changed, 2 insertions(+) diff --git a/.github/pull_request_template.md b/.github/pull_request_template.md index 41a9585a91e..991703ac122 100644 --- a/.github/pull_request_template.md +++ b/.github/pull_request_template.md @@ -14,4 +14,5 @@ - [ ] Generic behaviour, not specific to one title - [ ] Depends on: - [ ] Unblocks: +- [ ] GPUs tested: - [ ] AI-assisted: diff --git a/CONTRIBUTING.md b/CONTRIBUTING.md index f17bc7d74ca..b83c070c09b 100644 --- a/CONTRIBUTING.md +++ b/CONTRIBUTING.md @@ -60,6 +60,7 @@ The [pull request template](.github/pull_request_template.md) is the checklist f - The PR overlap comment lists open pull requests that change the same lines or exports; agree with their authors which one goes first and declare it with `Depends on`. - Run the tests before opening the pull request and describe what was tested (OS, title or homebrew). - A pull request that claims a change in speed shows the summary lines of `main` and of the change, from the same machine and scene, and attaches the traces, captured as the [Performance report](.github/ISSUE_TEMPLATE/performance.yml) issue form describes. A slow scene is reported with the same form. +- Changes to the AGC driver, the shader recompiler or VideoOut name each GPU the GPU tests ran on (vendor, model, driver, OS) on the `GPUs tested` checklist line. CI runs these tests only on lavapipe, and hardware drivers fail where lavapipe and other vendors pass, so a reviewer can ask for a run on another vendor before merging. - Investigation notes, reports, screenshots and logs go in the pull request, not in the repository. Images for documentation go in the [gist](https://gist.github.com/boykopovar/0e53f2e1426f29ecd41e3b51540b8a90) comments. - Say whether the change was written with AI assistance. The author of the pull request is responsible for every line of it.