Merge pull request #30 from faif/master

Syncing from upstream faif/python-patterns (master)

Author: bt-admin

.github/workflows/lint_pr.yml

@@ -7,7 +7,7 @@ jobs:
       has_python_changes: ${{ steps.changed-files.outputs.has_python_changes }}
       files: ${{ steps.changed-files.outputs.files }}
     steps:
-      - uses: actions/checkout@v3
+      - uses: actions/checkout@v6
         with:
           fetch-depth: 0 # To get all history for git diff commands
 
@@ -71,15 +71,15 @@ jobs:
             exit 0
           fi
 
-      - uses: actions/checkout@v3
+      - uses: actions/checkout@v6
         with:
           fetch-depth: 0
 
-      - uses: actions/setup-python@v4
+      - uses: actions/setup-python@v6
         with:
           python-version: 3.12
 
-      - uses: actions/cache@v3
+      - uses: actions/cache@v5
         with:
           path: ~/.cache/pip
           key: ${{ runner.os }}-pip-${{ hashFiles('requirements-dev.txt') }}
@@ -273,7 +273,7 @@ jobs:
     if: ${{ always() }}
     runs-on: ubuntu-24.04
     steps:
-      - uses: actions/checkout@v3
+      - uses: actions/checkout@v6
 
       - name: Summarize results
         run: |

.github/workflows/lint_python.yml

@@ -4,8 +4,8 @@ jobs:
   lint_python:
     runs-on: ubuntu-24.04
     steps:
-      - uses: actions/checkout@v3
-      - uses: actions/setup-python@v4
+      - uses: actions/checkout@v6
+      - uses: actions/setup-python@v6
         with:
           python-version: 3.12
       - name: Install dependencies

patterns/behavioral/chain_of_responsibility.py

@@ -14,6 +14,10 @@
 As a variation some receivers may be capable of sending requests out
 in several directions, forming a `tree of responsibility`.
 
+*Examples in Python ecosystem:
+Django Middleware: https://docs.djangoproject.com/en/stable/topics/http/middleware/
+The middleware components act as a chain where each processes the request/response.
+
 *TL;DR
 Allow a request to pass down a chain of receivers until it is handled.
 """

patterns/behavioral/memento.py

@@ -6,7 +6,7 @@
 """
 
 from copy import copy, deepcopy
-from typing import Callable, List
+from typing import Any, Callable, List, Type
 
 
 def memento(obj: Any, deep: bool = False) -> Callable:

patterns/structural/mvc.py

@@ -4,7 +4,6 @@
 """
 
 from abc import ABC, abstractmethod
-from ProductModel import Price
 from typing import Dict, List, Union, Any
 from inspect import signature
 from sys import argv

pytest_local.ini

@@ -0,0 +1,3 @@
+[pytest]
+addopts = -q
+testpaths = tests

tests/creational/test_factory.py

@@ -0,0 +1,30 @@
+import unittest
+from patterns.creational.factory import get_localizer, GreekLocalizer, EnglishLocalizer
+
+class TestFactory(unittest.TestCase):
+    def test_get_localizer_greek(self):
+        localizer = get_localizer("Greek")
+        self.assertIsInstance(localizer, GreekLocalizer)
+        self.assertEqual(localizer.localize("dog"), "σκύλος")
+        self.assertEqual(localizer.localize("cat"), "γάτα")
+        # Test unknown word returns the word itself
+        self.assertEqual(localizer.localize("monkey"), "monkey")
+
+    def test_get_localizer_english(self):
+        localizer = get_localizer("English")
+        self.assertIsInstance(localizer, EnglishLocalizer)
+        self.assertEqual(localizer.localize("dog"), "dog")
+        self.assertEqual(localizer.localize("cat"), "cat")
+
+    def test_get_localizer_default(self):
+        # Test default argument
+        localizer = get_localizer()
+        self.assertIsInstance(localizer, EnglishLocalizer)
+
+    def test_get_localizer_unknown_language(self):
+        # Test fallback for unknown language if applicable, 
+        # or just verify what happens. 
+        # Based on implementation: localizers.get(language, EnglishLocalizer)()
+        # It defaults to EnglishLocalizer for unknown keys.
+        localizer = get_localizer("Spanish")
+        self.assertIsInstance(localizer, EnglishLocalizer)

tests/fundamental/test_delegation.py

@@ -0,0 +1,16 @@
+import pytest
+
+from patterns.fundamental.delegation_pattern import Delegator, Delegate
+
+
+def test_delegator_delegates_attribute_and_call():
+    d = Delegator(Delegate())
+    assert d.p1 == 123
+    assert d.do_something("something") == "Doing something"
+    assert d.do_something("something", kw=", hi") == "Doing something, hi"
+
+
+def test_delegator_missing_attribute_raises():
+    d = Delegator(Delegate())
+    with pytest.raises(AttributeError):
+        _ = d.p2

tests/structural/test_facade.py

@@ -0,0 +1,11 @@
+from patterns.structural.facade import ComputerFacade
+
+
+def test_computer_facade_start(capsys):
+    cf = ComputerFacade()
+    cf.start()
+    out = capsys.readouterr().out
+    assert "Freezing processor." in out
+    assert "Loading from 0x00 data:" in out
+    assert "Jumping to: 0x00" in out
+    assert "Executing." in out

tests/structural/test_flyweight.py

@@ -0,0 +1,20 @@
+from patterns.structural.flyweight import Card
+
+
+def test_card_flyweight_identity_and_repr():
+    c1 = Card("9", "h")
+    c2 = Card("9", "h")
+    assert c1 is c2
+    assert repr(c1) == "<Card: 9h>"
+
+
+def test_card_attribute_persistence_and_pool_clear():
+    Card._pool.clear()
+    c1 = Card("A", "s")
+    c1.temp = "t"
+    c2 = Card("A", "s")
+    assert hasattr(c2, "temp")
+
+    Card._pool.clear()
+    c3 = Card("A", "s")
+    assert not hasattr(c3, "temp")