Skip to content
This repository has been archived by the owner on Dec 11, 2019. It is now read-only.

Merged Review Issue: unsafe eval #15020

Closed
tildelowengrimm opened this issue Aug 14, 2018 · 1 comment
Closed

Merged Review Issue: unsafe eval #15020

tildelowengrimm opened this issue Aug 14, 2018 · 1 comment

Comments

@tildelowengrimm
Copy link

This is one of the PR issues from #14734

Check this out: #14734 (comment)

@mrose17
Copy link
Member

mrose17 commented Aug 15, 2018

there are two illuminating posts:

which come down to the same issue we are seeing. the latter issue is perhaps more instructive when looking at https://github.com/brave/browser-laptop/blob/master/app/extensions.js#L305

@diracdeltas - the short answer to #14734 (comment) is that, at present, the answer appears to be yes ... providing that i can review the code corresponding to the two hashes. i have asked the metamask folks for help in identifying the fragments for review.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

3 participants