Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

All font variables in css should specify a fallback #482

Open
petemill opened this issue Nov 16, 2023 · 3 comments
Open

All font variables in css should specify a fallback #482

petemill opened this issue Nov 16, 2023 · 3 comments

Comments

@petemill
Copy link
Member

Fallback should at least be sans-serif

@AlanBreck
Copy link
Collaborator

@aguscruiz, can you define fallback fonts in Figma which can be included in the export?

@aguscruiz
Copy link
Collaborator

@aguscruiz, can you define fallback fonts in Figma which can be included in the export?

No, sadly I can't define that in Figma. But if it helps, we could use this
https://systemfontstack.com/

@AlanBreck
Copy link
Collaborator

My larger concern is that since it's not configurable in Figma, and therefore included in the export, we'll have to hard code that the fallback is sans-serif, so if we ever introduced serif (like with Fletcha for marketing), we'd have to hardcode a mapping for the fonts to their fallbacks.

Not a big deal, especially given the limited number of fonts we use. Just not ideal.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants