Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Colors]: Secondary color should not look bad when used next to the primary color #838

Open
fallaciousreasoning opened this issue Sep 18, 2024 · 1 comment
Assignees

Comments

@fallaciousreasoning
Copy link
Collaborator

fallaciousreasoning commented Sep 18, 2024

In Chromium, the Secondary color is used in dark mode in a bunch of tonal values - this does not look great
brave/brave-browser#41125

We should change the Nala secondary color to something we can safely use by default 😄

If we don't we're going to be going against the grain in Chromium, and its going to make our lives harder.

Example screenshots:

image

image

@aguscruiz
Copy link
Collaborator

@fallaciousreasoning this one is gonna be a problem 😬.

Do you know if chromium is using the same value for primary/secondary in their themes? I can't really tell but it seems like it's a different shade of blue between primary/secondary.

Good call on disabling the tonal in the meantime, but I don't really understand how chromium intends to use the primary/secondary combination there in just the outline of the buttons? That's super weird to me. I don't see how their color combinations would look ok either unless it's the same value

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants