Skip to content

Commit 6d4f141

Browse files
author
Archish Thakkar
authored
Merge pull request #641 from browserstack/OBS_1750_change_defaults
Change defaults w.r.t build artifacts
2 parents 221ccc2 + a870f83 commit 6d4f141

File tree

1 file changed

+4
-1
lines changed

1 file changed

+4
-1
lines changed

bin/testObservability/helper/helper.js

Lines changed: 4 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -741,6 +741,9 @@ exports.setTestObservabilityFlags = (bsConfig) => {
741741
/* testObservability */
742742
let isTestObservabilitySession = false;
743743
try {
744+
/* set default again but under try catch in case of wrong config */
745+
isTestObservabilitySession = utils.nonEmptyArray(bsConfig.run_settings.downloads) ? false : true;
746+
744747
if(!utils.isUndefined(bsConfig["testObservability"])) isTestObservabilitySession = ( bsConfig["testObservability"] == true || bsConfig["testObservability"] == 1 );
745748
if(!utils.isUndefined(process.env.BROWSERSTACK_TEST_OBSERVABILITY)) isTestObservabilitySession = ( process.env.BROWSERSTACK_TEST_OBSERVABILITY == "true" || process.env.BROWSERSTACK_TEST_OBSERVABILITY == "1" );
746749
if(process.argv.includes('--disable-test-observability')) isTestObservabilitySession = false;
@@ -750,7 +753,6 @@ exports.setTestObservabilityFlags = (bsConfig) => {
750753
exports.debug(`EXCEPTION while parsing testObservability capability with error ${e}`, true, e);
751754
}
752755

753-
754756
/* browserstackAutomation */
755757
let isBrowserstackInfra = true;
756758
try {
@@ -762,6 +764,7 @@ exports.setTestObservabilityFlags = (bsConfig) => {
762764
exports.debug(`EXCEPTION while parsing browserstackAutomation capability with error ${e}`, true, e);
763765
}
764766

767+
if(isTestObservabilitySession) logger.warn("testObservability is set to true. Other test reporters you are using will be automatically disabled. Learn more at browserstack.com/docs/test-observability/overview/what-is-test-observability");
765768

766769
process.env.BROWSERSTACK_TEST_OBSERVABILITY = isTestObservabilitySession;
767770
process.env.BROWSERSTACK_AUTOMATION = isBrowserstackInfra;

0 commit comments

Comments
 (0)