-
Notifications
You must be signed in to change notification settings - Fork 39
Add section API #207
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add section API #207
Conversation
|
Hi @tymokvo, thanks for the PR! And sorry for the late response on it. I skimmed through the PR and it's looking good, thanks for adding an example as well! Just FYI, the next thing I hope to accomplish in this repo is to have a more systematic approach to generating the bindings. This includes logically organizing the OpenCascade modules into equivalently named Rust modules. You can see a manual example of that process in this PR: But obviously manually creating those are a pain, so I'm also working on generating them by parsing the C++ headers with tree-sitter and writing out the Rust code automatically. That work is happening in the tree-sitter branch. I just wanted to give you an idea of what I hope this crate will turn into in the future. I'll try to give this a closer review soon. |
|
The work on the |
bschwind
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Overall this looks great! I left a few comments, and I have one tiny preference to have literal floating point numbers have leading and trailing zeroes:
0. -> 0.0
.1 -> 0.1
etc.Co-authored-by: Brian Schwind <[email protected]>
Co-authored-by: Brian Schwind <[email protected]>
Co-authored-by: Brian Schwind <[email protected]>
bschwind
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! I'll merge this once CI passes. Thanks for the PR and thanks for waiting :)
|
Thanks for the help and for making a great library! |
Summary
BRepAlgoAPI_Sectionclasswrapper.hxxsectionexampleDescription
Hello,
I have been evaluating CAD libraries in the rust ecosystem for a project at work. In order to test out some of the capabilities of
opencascade-rs, I took a stab at implementing a simple wrapper around theBRepAlgoAPI_Sectionclass.The most complicated aspect was dealing with the inherited methods from the
BRepAlgoAPIclass hierarchy. I followed the advice from an issue oncxxon how to deal with this, hence the addition towrapper.hxx.Would this be a useful addition? I know that it's a bit rough right now, I haven't used
cxxbefore! Would love to hear any feedback on this direction, though.