[feature] Add an ‘add-definitions’ option

[gmh5225]

Would like to add an add-definitions option. Sometimes compile-definitions doesn't work so well.

[mrexodia]

add_definition is bad practice and I don’t want to generate that. Could you show an example of where compile-definitions doesn’t work, maybe something needs to be fixed there instead.

[gmh5225]

add_definition is bad practice and I don’t want to generate that. Could you show an example of where compile-definitions doesn’t work, maybe something needs to be fixed there instead.

You can use this project as a test. It mainly refers to the LLVM macro definitions
compile-definitions = ["${LLVM_DEFINITIONS}", "${CLANG_DEFINITIONS}"]
And then Visual Studio's Intellisense will report an error.

But
add_definitions(${LLVM_DEFINITIONS})
add_definitions(${CLANG_DEFINITIONS})
is ok.

[mrexodia]

The reason is that you are adding a single flag and not multiple. Using variables isn’t really supported in this way with cmkr, but I’ll give it a try later.

Instead I recommend using: https://github.com/LLVMParty/LLVMCMakeTemplate/blob/master/cmake/LLVM.cmake

You can use include-after and then link to the LLVM-Wrapper target.

[gmh5225]

Wow. I see.
This project looks good.
Thank you.

[gmh5225]

I'm not sure if this can be merged.
But It works for me now fix
Finally many thanks for this project :)

[mrexodia]

Might be an idea to allow:

[project]
name = "foo"
msvc.compile-definitions = ["MSVC_BUILD"]
generator-vs.compile-options = ["/MP"]
msvc.link-options = [
    "$<$<CONFIG:Release>:/DEBUG:FULL>",
    "$<$<CONFIG:Release>:/INCREMENTAL:NO>",
    "$<$<CONFIG:Release>:/OPT:REF>",
    "$<$<CONFIG:Release>:/OPT:ICF>",
]