Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add HostnamePort::localhost(u16) constructor to HostnamePort #8712

Closed
adrianbenavides opened this issue Dec 18, 2024 · 3 comments · Fixed by #8737
Closed

Add HostnamePort::localhost(u16) constructor to HostnamePort #8712

adrianbenavides opened this issue Dec 18, 2024 · 3 comments · Fixed by #8737
Assignees
@ilyaaay
Labels
Component: Command good first issue help wanted Implementation: Rust

Comments

@adrianbenavides
Copy link
Member

Current behavior

We currently use HostnamePort::new("127.0.0.1", 0) which returns a result, and in this case, we know it's a valid hostname.

Desired behavior

Add a new constructor HostnamePort::localhost(u16) that doesn't return a Result and replace usages.
@adrianbenavides adrianbenavides mentioned this issue Dec 18, 2024
Merged
@ilyaaay
Copy link
Contributor

ilyaaay commented Jan 10, 2025

@adrianbenavides #8737

@adrianbenavides adrianbenavides linked a pull request Jan 16, 2025 that will close this issue
refactor(rust): use localhost constructor for HostnamePort #8737
Merged
@ilyaaay
Copy link
Contributor

ilyaaay commented Jan 31, 2025

@adrianbenavides Hi. What about my PR?

@adrianbenavides
Copy link
Member Author

Hey @ilyaaay I'll prepare it to merge today. We've been busy landing a lot of changes in the command and there are some conflicts I need to fix.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ilyaaay ilyaaay

Labels
Component: Command good first issue help wanted Implementation: Rust
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

refactor(rust): use localhost constructor for HostnamePort ilyaaay/ockam
2 participants
@adrianbenavides @ilyaaay