Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cannot type comma (,) gets deleted automatically #51

Open
Santosh-13 opened this issue May 4, 2022 · 7 comments
Open

Cannot type comma (,) gets deleted automatically #51

Santosh-13 opened this issue May 4, 2022 · 7 comments

Comments

@Santosh-13
Copy link

Typed ram,

image

clicked space

image

Actual - the comma got lost,
Expected/Suggestion - show comma in the suggestion aswell

@Santosh-13
Copy link
Author

@burhanuday , just want to check are you still managing this repo as I don't see any updates in this repo recently.

@burhanuday
Copy link
Owner

@Santosh-13 Here's probably what's going on. I take the last word typed by the user by splitting the sentence by the space characters. ram, is getting picked as the last word. so far so good
then ram, gets sent to the Google transliteration API which is removing the punctuation in the result. Can you open a PR that fixes this logic?

the expected way should be that if its a punctuation at the end, it should be removed from being sent to the api and then get readded to the result

temporary workaround is to select option first and then add the punctuation

@Santosh-13
Copy link
Author

@Santosh-13 Here's probably what's going on. I take the last word typed by the user by splitting the sentence by the space characters. ram, is getting picked as the last word. so far so good then ram, gets sent to the Google transliteration API which is removing the punctuation in the result. Can you open a PR that fixes this logic?

the expected way should be that if its a punctuation at the end, it should be removed from being sent to the api and then get readded to the result

temporary workaround is to select option first and then add the punctuation

looks like i dont have write access on this repo, can you provide it

@burhanuday
Copy link
Owner

@Santosh-13 please fork the repo and send a pull request

@Santosh-13
Copy link
Author

@burhanuday , please take a look at this PR - #52

1 similar comment
@Santosh-13
Copy link
Author

@burhanuday , please take a look at this PR - #52

@Santosh-13
Copy link
Author

@burhanuday , please take a look at this PR - #52 for this issue fix

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants