Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixed issue with flush reading array out of bounds #3

Merged
merged 3 commits into from
Jul 12, 2019
Merged

Fixed issue with flush reading array out of bounds #3

merged 3 commits into from
Jul 12, 2019

Conversation

samfoucart
Copy link
Contributor

Fixes #528 on ogv.js.
Before, the array could be indexed at -1 giving an undefined reference.
image

@samfoucart
Copy link
Contributor Author

Do you want me to run npm install to run the grunt commands, or do you want only the one file modified?

@velochy
Copy link
Owner

velochy commented Jul 10, 2019 •
edited
Loading

@samfoucart can you run the build process too, please :)

@velochy velochy merged commit 2f40479 into velochy:master Jul 12, 2019
@velochy
Copy link
Owner

velochy commented Jul 12, 2019

@samfoucart Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

New player 1.6.1 breaking seek
3 participants
@samfoucart @velochy @samfoucart-niceincontact