Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

components: Text format does not disambiguate function alias binary encodings #588

Closed
alexcrichton opened this issue May 12, 2022 · 0 comments · Fixed by #621
Closed

components: Text format does not disambiguate function alias binary encodings #588

alexcrichton opened this issue May 12, 2022 · 0 comments · Fixed by #621
Labels
wast Related to the text format of WebAssembly (wat/wast)

Comments

@alexcrichton
Copy link
Member

As-is right this red hot second the text format for the component model specifies a different binary encoding for aliasing functions from a component instance vs functions from a module instance. This difference in binary encoding, however, is not reflected in the AST or text format (they both simply use "func"). This is slated to get fixed with WebAssembly/component-model#29, however.

I'm filing this issue as a placeholder to write down in tests. Some tests that should be valid or have a different error message will instead have this error message since function aliases in wast are always encoded as core wasm function aliases instead of sometimes component function aliases.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
wast Related to the text format of WebAssembly (wat/wast)
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant