Skip to content

Incorrect Documentation for Worker, where it refers that options parameter provides things like DataConverter #866

Open
@Krashcan

Description

@Krashcan

This is what the documentation is for Worker constructor

/**
   * Creates worker that connects to an instance of the Cadence Service.
   *
   * @param client client to the Cadence Service endpoint.
   * @param taskList task list name worker uses to poll. It uses this name for both decision and
   *     activity task list polls.
   * @param options Options (like {@link DataConverter} override) for configuring worker.
   */

link

WorkerOptions have changed now and no longer have DataConverter . DataConverter is being passed via client.getOptions().getDataConverter() . Documentation should be modified so that it is relevant to the current state.

Activity

Krashcan

Krashcan commented on Feb 28, 2024

@Krashcan
Author
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

      Development

      No branches or pull requests

        Participants

        @Krashcan@demirkayaender

        Issue actions

          Incorrect Documentation for Worker, where it refers that options parameter provides things like DataConverter · Issue #866 · cadence-workflow/cadence-java-client