Skip to content

support for "test runner for java" extension in vscode #1001

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

shijiesheng
Copy link
Member

@shijiesheng shijiesheng commented May 20, 2025

What changed?

  • disable ErrorProne checks (some files are already violating but is suppressed due to Xlint:none)

Why?

Test Runner for Java extension for some reason doesn't read Xlint:none flag and thus fails on suppressed lint errors

How did you test it?

Locally tested on vscode

Before
Screenshot 2025-05-20 at 12 47 32 PM

After
Screenshot 2025-05-20 at 12 48 56 PM

Potential risks

Release notes

Documentation Changes

@shijiesheng shijiesheng changed the title support for testrunner for java in vscode support for "test runner for java" extension in vscode May 20, 2025
Copy link
Member

@natemort natemort left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved, once we're in v 4.x we should be able to reintroduce these and upgrade the gradle version

@shijiesheng shijiesheng merged commit 5cbf89e into cadence-workflow:master May 20, 2025
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants