test(daemon): tighten provider-not-registered assertions and document exemptions

Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>

Author: thymikee

packages/daemon/src/sessions/handlers/__tests__/lease.test.ts

@@ -662,7 +662,13 @@ test('lease_allocate treats a daemon that reports no provider runtimes as having
       sessionStore: makeSessionStore('agent-device-no-runtimes-'),
       leaseRegistry: new LeaseRegistry(),
     }),
-    (error: unknown) =>
-      error instanceof AppError && error.details?.registeredProviders !== undefined,
+    (error: unknown) => {
+      assert.ok(error instanceof AppError);
+      assert.equal(error.code, 'UNSUPPORTED_OPERATION');
+      assert.equal(error.details?.reason, 'provider-not-registered');
+      assert.equal(error.details?.provider, 'browserstack');
+      assert.deepEqual(error.details?.registeredProviders, []);
+      return true;
+    },
   );
 });

src/daemon-composition-credentials.test.ts

@@ -31,7 +31,16 @@ vi.mock('./platform-runtime.ts', () => ({
 vi.mock('./provider-device-runtimes.ts', () => ({
   DEFAULT_PROVIDER_RUNTIME_REQUIRED_IDS: [],
   createDaemonProviderRuntimeComposition: async () => ({
-    runtimes: [{ provider: 'browserstack', ownsDevice: () => false }],
+    runtimes: [
+      {
+        provider: 'browserstack',
+        leaseLifecycle: {},
+        deviceInventoryProvider: { discover: async () => [] },
+        ownsDevice: () => false,
+        getInteractor: () => undefined,
+        shutdown: async () => {},
+      },
+    ],
     platformModules: [],
   }),
 }));
@@ -80,7 +89,9 @@ test('daemon startup compares lease credentials with its own startup environment
     expect(await allocate({ ...daemonEnv, BROWSERSTACK_ACCESS_KEY: 'key-2' })).toContain(
       'provider-credentials-changed',
     );
-    expect(await allocate(daemonEnv)).not.toContain('provider-credentials-changed');
+    const accepted = await allocate(daemonEnv);
+    expect(accepted).not.toContain('provider-credentials-changed');
+    expect(accepted).toContain('leaseId');
   } finally {
     await runtime?.shutdown();
   }

website/docs/docs/client-api.md

@@ -252,7 +252,7 @@ Domain client methods:
 - `client.sessions.list()`, `stateDir()`, `close()`, `saveScript()`, `artifacts()`
 - `client.apps.install()`, `reinstall()`, `uninstall()`, `installFromSource()`, `list()`, `open()`, `close()`, `push()`, `triggerEvent()`
 - `client.materializations.release()`
-- `client.leases.allocate()`, `heartbeat()`, `release()`. Pass `retainOnClose: true` to `allocate()` when you release the lease yourself; session `close` then leaves it active until `release()`, expiry, or daemon shutdown. The returned lease has `retainOnClose: true` only when the daemon honored it. Keep heartbeating a retained lease between sessions: it expires after its `ttlMs` like any other lease. Pass `leaseId` (16 to 128 hex characters) to `allocate()` to name a new lease with an id the daemon has never issued, or to get back your live lease with that id when you retry with the same tenant, run, client, lease backend, and provider (and no device, or the leased one), then use the returned `leaseId`: a run that already holds a lease gets that one back, and an older daemon mints its own. `allocate()` with a `leaseProvider` the daemon has no runtime for fails with `UNSUPPORTED_OPERATION`, reason `provider-not-registered`, and `details.registeredProviders`; no lease is recorded.
+- `client.leases.allocate()`, `heartbeat()`, `release()`. Pass `retainOnClose: true` to `allocate()` when you release the lease yourself; session `close` then leaves it active until `release()`, expiry, or daemon shutdown. The returned lease has `retainOnClose: true` only when the daemon honored it. Keep heartbeating a retained lease between sessions: it expires after its `ttlMs` like any other lease. Pass `leaseId` (16 to 128 hex characters) to `allocate()` to name a new lease with an id the daemon has never issued, or to get back your live lease with that id when you retry with the same tenant, run, client, lease backend, and provider (and no device, or the leased one), then use the returned `leaseId`: a run that already holds a lease gets that one back, and an older daemon mints its own. `allocate()` with a `leaseProvider` the daemon has no runtime for fails with `UNSUPPORTED_OPERATION`, reason `provider-not-registered`, and `details.registeredProviders`; no lease is recorded. Leases with no provider, `proxy`, or `cloud` need no runtime.
 - `client.metro.prepare()`, `reload()`
 - `client.capture.snapshot()`, `screenshot()`, `diff()`
 - `client.interactions.click()`, `press()`, `longPress()`, `swipe()`, `pan()`, `drag()`, `fling()`, `swipeGesture()`, `focus()`, `type()`, `fill()`, `scroll()`, `pinch()`, `rotateGesture()`, `transformGesture()`, `get()`, `is()`, `find()`