refactor(mcp): project push management family output schemas from their owning module (#3029)

* refactor(mcp): project push management family output schemas from their owning module

Moves the 2 hand-authored MCP outputSchema entries for push and
trigger-app-event out of command-output-schemas.ts into a frozen
PUSH_MANAGEMENT_COMMAND_OUTPUT_SCHEMAS map exported from
src/commands/management/push.ts, following the #2810 projection seam
already used by the replay, system, interaction, and device-management
families on this stack. Registers the family in the PROJECTED_FAMILIES
disjointness check and adds a colocated
command-tools-management-push-schemas.test.ts proving reference equality
with the module object. Neither command carries the post-action
observation trait, so no settle-graft copy applies here.

The moved code is byte-identical to what command-output-schemas.ts held:
same objectSchema/stringSchema/numberSchema calls and field order, with a
locally duplicated constSchema helper matching the precedent from the
interaction, system, and device-management families' moves.

Part of #2819.

* refactor(mcp): import the shared constSchema in the push management family

Author: thymikee

src/commands/management/push.ts

@@ -4,6 +4,7 @@ import type {
   JsonObject,
 } from '@agent-device/contracts/client';
 import type { CommandSchemaOverride } from '@agent-device/command-registry/command-schema';
+import type { CommandResultMap } from '@agent-device/command-registry/command-result';
 import { PUBLIC_COMMANDS } from '@agent-device/command-registry/catalog';
 import {
   commonInputFromFlags,
@@ -12,10 +13,14 @@ import {
   requiredString,
 } from '../cli-grammar/common.ts';
 import type { CliReader, DaemonWriter } from '../cli-grammar/types.ts';
+import type { JsonSchema } from '../command-contract.ts';
 import {
+  constSchema,
   jsonSchemaField,
   looseObjectField,
   looseObjectSchema,
+  numberSchema,
+  objectSchema,
   requiredField,
   stringField,
   stringSchema,
@@ -24,6 +29,47 @@ import {
 import { defineCommandFacet } from '../family/types.ts';
 import { defineFieldCommandMetadata } from '../field-command-contract.ts';
 
+/**
+ * This family's advertised MCP `outputSchema`s, keyed by daemon command name and projected into
+ * the command map by `src/mcp/command-output-schemas.ts`. Non-strict like every other entry: no
+ * `additionalProperties: false`, so additive response fields such as `cost` keep validating.
+ * Neither command carries the post-action observation trait (#1652): both fire-and-report a push
+ * delivery or an app event, not an interaction, so no settle graft applies here.
+ */
+export const PUSH_MANAGEMENT_COMMAND_OUTPUT_SCHEMAS = {
+  // packages/contracts/src/push.ts — discriminated union on public platform.
+  push: {
+    type: 'object',
+    oneOf: [
+      objectSchema(
+        { platform: constSchema('ios'), bundleId: stringSchema(), message: stringSchema() },
+        ['platform', 'bundleId', 'message'],
+      ),
+      objectSchema(
+        {
+          platform: constSchema('android'),
+          package: stringSchema(),
+          action: stringSchema(),
+          extrasCount: numberSchema(),
+          message: stringSchema(),
+        },
+        ['platform', 'package', 'action', 'extrasCount', 'message'],
+      ),
+    ],
+  },
+
+  // packages/contracts/src/app-events.ts
+  'trigger-app-event': objectSchema(
+    {
+      event: stringSchema(),
+      eventUrl: stringSchema(),
+      transport: constSchema('deep-link'),
+      message: stringSchema(),
+    },
+    ['event', 'eventUrl', 'transport', 'message'],
+  ),
+} satisfies Pick<Record<keyof CommandResultMap, JsonSchema>, 'push' | 'trigger-app-event'>;
+
 const pushCommandMetadata = defineFieldCommandMetadata(
   'push',
   'Deliver push notification payloads to an installed app.',

src/mcp/__tests__/command-tools-management-push-schemas.test.ts

@@ -0,0 +1,31 @@
+import assert from 'node:assert/strict';
+import { test } from 'vitest';
+import { ownerFilesForCommand } from '@agent-device/command-registry/owner-files';
+import { PUSH_MANAGEMENT_COMMAND_OUTPUT_SCHEMAS } from '../../commands/management/push.ts';
+import { COMMAND_OUTPUT_SCHEMAS } from '../command-output-schemas.ts';
+
+const PUSH_MANAGEMENT_COMMANDS = Object.keys(PUSH_MANAGEMENT_COMMAND_OUTPUT_SCHEMAS) as Array<
+  keyof typeof PUSH_MANAGEMENT_COMMAND_OUTPUT_SCHEMAS
+>;
+
+// Neither push nor trigger-app-event carries the post-action observation trait (#1652): both
+// fire-and-report a push delivery or an app event, not an interaction, so the composed map never
+// copies either entry and reference equality must hold for both.
+test('MCP push management family output schemas are the family module entries, not copies', () => {
+  for (const command of PUSH_MANAGEMENT_COMMANDS) {
+    assert.equal(
+      COMMAND_OUTPUT_SCHEMAS[command],
+      PUSH_MANAGEMENT_COMMAND_OUTPUT_SCHEMAS[command],
+      `${command} is not reference-equal to the push management module's own schema object`,
+    );
+  }
+});
+
+test('the projected family map declares exactly the commands its module owns', () => {
+  for (const command of PUSH_MANAGEMENT_COMMANDS) {
+    assert.ok(
+      ownerFilesForCommand(command).includes('src/commands/management/push.ts'),
+      `${command} projects its output schema from this module but does not name it as its owner`,
+    );
+  }
+});

src/mcp/__tests__/command-tools-replay-schemas.test.ts

@@ -4,6 +4,7 @@ import type { ReplayCommandResult, ReplaySuiteResult } from '@agent-device/contr
 import { ownerFilesForCommand } from '@agent-device/command-registry/owner-files';
 import { commandSupportsSettleObservation } from '@agent-device/command-registry/registry';
 import { DEVICE_MANAGEMENT_COMMAND_OUTPUT_SCHEMAS } from '../../commands/management/device.ts';
+import { PUSH_MANAGEMENT_COMMAND_OUTPUT_SCHEMAS } from '../../commands/management/push.ts';
 import { INTERACTION_COMMAND_OUTPUT_SCHEMAS } from '../../commands/interaction/index.ts';
 import { REPLAY_COMMAND_OUTPUT_SCHEMAS } from '../../commands/replay/index.ts';
 import { SYSTEM_COMMAND_OUTPUT_SCHEMAS } from '../../commands/system/index.ts';
@@ -75,6 +76,7 @@ const PROJECTED_FAMILIES = [
   { name: 'system', schemas: SYSTEM_COMMAND_OUTPUT_SCHEMAS },
   { name: 'interaction', schemas: INTERACTION_COMMAND_OUTPUT_SCHEMAS },
   { name: 'management-device', schemas: DEVICE_MANAGEMENT_COMMAND_OUTPUT_SCHEMAS },
+  { name: 'management-push', schemas: PUSH_MANAGEMENT_COMMAND_OUTPUT_SCHEMAS },
 ] as const;
 
 test('projected output-schema families claim disjoint commands and survive the composition intact', () => {

src/mcp/command-output-schemas.ts

@@ -12,6 +12,7 @@ import {
   stringSchema,
 } from '../commands/command-input.ts';
 import { DEVICE_MANAGEMENT_COMMAND_OUTPUT_SCHEMAS } from '../commands/management/device.ts';
+import { PUSH_MANAGEMENT_COMMAND_OUTPUT_SCHEMAS } from '../commands/management/push.ts';
 import {
   INTERACTION_COMMAND_OUTPUT_SCHEMAS,
   postActionSurfaceChangeSchema,
@@ -272,38 +273,6 @@ const BASE_COMMAND_OUTPUT_SCHEMAS = {
     ],
   ),
 
-  // packages/contracts/src/push.ts — discriminated union on public platform.
-  push: {
-    type: 'object',
-    oneOf: [
-      objectSchema(
-        { platform: constSchema('ios'), bundleId: stringSchema(), message: stringSchema() },
-        ['platform', 'bundleId', 'message'],
-      ),
-      objectSchema(
-        {
-          platform: constSchema('android'),
-          package: stringSchema(),
-          action: stringSchema(),
-          extrasCount: numberSchema(),
-          message: stringSchema(),
-        },
-        ['platform', 'package', 'action', 'extrasCount', 'message'],
-      ),
-    ],
-  },
-
-  // packages/contracts/src/app-events.ts
-  'trigger-app-event': objectSchema(
-    {
-      event: stringSchema(),
-      eventUrl: stringSchema(),
-      transport: constSchema('deep-link'),
-      message: stringSchema(),
-    },
-    ['event', 'eventUrl', 'transport', 'message'],
-  ),
-
   // packages/contracts/src/doctor.ts
   doctor: objectSchema(
     {
@@ -430,6 +399,7 @@ const BASE_COMMAND_OUTPUT_SCHEMAS = {
   // a projected command then fails as TS2783 instead of quietly overriding the family's,
   // and this map's `satisfies` still refuses a missing `CommandResultMap` key.
   ...DEVICE_MANAGEMENT_COMMAND_OUTPUT_SCHEMAS,
+  ...PUSH_MANAGEMENT_COMMAND_OUTPUT_SCHEMAS,
   ...INTERACTION_COMMAND_OUTPUT_SCHEMAS,
   ...REPLAY_COMMAND_OUTPUT_SCHEMAS,
   ...SYSTEM_COMMAND_OUTPUT_SCHEMAS,