test(daemon): decoy session under the bare name for the recording close test

The recording step no longer re-reads the stored session in the teardown;
finishSessionScreenRecording already does that by address and returns
when there is no recording, so the duplicate lookup was only a second
place to mis-address. The recording test stores a second session with
its own live recording under the bare name "default": if the step goes
back to session.name, close finishes the decoy's recording instead of
the addressed one and the test fails on both counts.

Author: AdzeB

src/daemon/session-lifecycle/internal/__tests__/session-close-cwd-scoped-resources.test.ts

@@ -75,13 +75,30 @@ test('close finishes the recording of a cwd-scoped session by store address', as
   const resourcePath = screenRecordingResourceStore.resolvePath(
     sessionStore.resolveSessionDir(ADDRESS),
   );
+  // `--session default` addresses a *different* session stored under the bare name. Give it
+  // its own live recording so a `currentSession` lookup by `session.name` would finish the
+  // wrong one instead of falling back to `session` and staying green.
+  const decoy = makeIosSimulatorRecordingSession(sessionStore, NAME, {
+    device: { ...IOS_SIM, id: 'decoy-udid', name: 'iPhone 15' },
+  });
+  const decoyFinish = recordingFinishMock(decoy);
+  sessionStore.set(NAME, decoy);
+  const decoyResourcePath = screenRecordingResourceStore.resolvePath(
+    sessionStore.resolveSessionDir(NAME),
+  );
 
   const response = await closeAtAddress(sessionStore);
 
   expect(response?.ok).toBe(true);
   expect(finish).toHaveBeenCalledOnce();
   expectCompleted(screenRecordingResourceStore, resourcePath);
   expect(sessionStore.get(ADDRESS)).toBeUndefined();
+  // The decoy is untouched: not finished, record still open, session still stored.
+  expect(decoyFinish).not.toHaveBeenCalled();
+  const decoyRecord = screenRecordingResourceStore.read(decoyResourcePath);
+  expect(decoyRecord.status).toBe('decoded');
+  if (decoyRecord.status === 'decoded') expect(decoyRecord.envelope.lifecycle).toBe('open');
+  expect(sessionStore.get(NAME)).toBeDefined();
 });
 
 test('close stops the app log of a cwd-scoped session by store address', async () => {

src/daemon/session-lifecycle/internal/session-close-lifecycle-teardown.ts

@@ -135,17 +135,13 @@ async function stopBestEffortSessionResources(
   platformCleanup: PlatformResourceCleanup,
 ): Promise<void> {
   const { address: sessionName, session } = ref;
-  // Recording overlay finalization needs the Apple runner.
-  const currentSession = sessionStore.get(sessionName) ?? session;
-  if (currentSession.screenRecording) {
-    await attemptCleanup('recording', () =>
-      finishSessionScreenRecording({
-        session: currentSession,
-        sessionName,
-        sessionStore,
-      }),
-    );
-  }
+  // Recording overlay finalization needs the Apple runner, so it runs first.
+  // `finishSessionScreenRecording` re-reads the stored session by address and
+  // returns when there is no recording; a second lookup here would only be a
+  // place to mis-address it.
+  await attemptCleanup('recording', () =>
+    finishSessionScreenRecording({ session, sessionName, sessionStore }),
+  );
   await attemptCleanup('app_log', () => stopSessionAppLog({ session, sessionName, sessionStore }));
   await attemptCleanup('audio_probe', () =>
     finishSessionAudioProbe({ session, sessionName, sessionStore }),