fix: improve subview foreach, use view as identifier

Author: okwasniewski

packages/react-native-bottom-tabs/ios/TabView/LegacyTabView.swift

@@ -10,8 +10,10 @@ struct LegacyTabView: AnyTabView {
   @ViewBuilder
   var body: some View {
     TabView(selection: $props.selectedPage) {
-      ForEach(props.children.indices, id: \.self) { index in
-        renderTabItem(at: index)
+      ForEach(props.children, id: \.self) { child in
+        if let index = props.children.firstIndex(of: child) {
+          renderTabItem(at: index)
+        }
       }
       .measureView { size in
         onLayout(size)

packages/react-native-bottom-tabs/ios/TabView/NewTabView.swift

@@ -3,33 +3,32 @@ import SwiftUI
 @available(iOS 18, macOS 15, visionOS 2, tvOS 18, *)
 struct NewTabView: AnyTabView {
   @ObservedObject var props: TabViewProps
-
+  
   var onLayout: (CGSize) -> Void
   var onSelect: (String) -> Void
   var updateTabBarAppearance: () -> Void
-
+  
   @ViewBuilder
   var body: some View {
     TabView(selection: $props.selectedPage) {
-      ForEach(props.children.indices, id: \.self) { index in
-        if let tabData = props.items[safe: index] {
+      ForEach(props.children, id: \.self) { child in
+        if let index = props.children.firstIndex(of: child),
+           let tabData = props.items[safe: index] {
           let isFocused = props.selectedPage == tabData.key
-
+          
           if !tabData.hidden || isFocused {
             let icon = props.icons[index]
-
-            let platformChild = props.children[safe: index] ?? PlatformView()
-            let child = RepresentableView(view: platformChild)
+            
             let context = TabAppearContext(
               index: index,
               tabData: tabData,
               props: props,
               updateTabBarAppearance: updateTabBarAppearance,
               onSelect: onSelect
             )
-
+            
             Tab(value: tabData.key, role: tabData.role?.convert()) {
-              child
+              RepresentableView(view: child)
                 .ignoresSafeArea(.container, edges: .all)
                 .tabAppear(using: context)
             } label: {