fix(warm-pool): a waiter's boot is held back under the device's spec (#774)

Author: V3RON

src/core/warm-pool/policy.test.ts

@@ -306,6 +306,16 @@ describe("warm pool policy", () => {
       { action: "boot", deviceId: "lse_15", reason: "waiting-request" },
     ]);
     expect(evaluate(view([released], { waiting, blocked: [spec("iPhone 15")] }))).toEqual([]);
+
+    // why: the converger records the failure under the device's spec, which a class waiter's may differ from.
+    const other = device("lse_17", "shutdown", {
+      endedAgo: 90 * minute,
+      spec: spec("iPhone 17"),
+    });
+    expect(evaluate(view([other], { waiting }))).toEqual([
+      { action: "boot", deviceId: "lse_17", reason: "waiting-request" },
+    ]);
+    expect(evaluate(view([other], { waiting, blocked: [spec("iPhone 17")] }))).toEqual([]);
   });
 
   it("proposes a boot, not a shutdown, for a released iPhone 15 that serves a waiting class request at the running cap", () => {

src/core/warm-pool/policy.ts

@@ -370,12 +370,14 @@ function bootsOpen(state: QueueState): boolean {
 }
 
 function bootForWaiter(state: QueueState, demand: WaitingDemand): boolean {
-  if (!bootsOpen(state) || !state.view.retry.mayAttempt(demand.spec, state.view.now)) return false;
+  if (!bootsOpen(state)) return false;
   const device = state.bootable.find(
     (candidate) =>
       !state.taken.has(candidate.id) &&
       hasRoom(state.room, candidate) &&
       serves(candidate, demand) &&
+      // why: the converger records a failed boot under the device's spec, not the waiter's.
+      state.view.retry.mayAttempt(candidate.spec, state.view.now) &&
       state.view.admit.boot(candidate) === undefined,
   );
   if (device === undefined) return false;