Button allows any string for appearance

[ethanashaw]

The Button component allows any string for its appearance:

react-components/src/components/Button/Button.tsx

Line 30 in 60dd444

appearance?: ValueOf<typeof ButtonAppearance> | string;

Could it be restricted to ValueOf<typeof ButtonAppearance>?

[huwshimi]

Hi @ethanashaw, string is supported so that custom button variations (classes) can be created within projects and used with this component. Possibly we could adjust the type so that it suggests the values in your IDE.

[ethanashaw]

Hi @ethanashaw, string is supported so that custom button variations (classes) can be created within projects and used with this component. Possibly we could adjust the type so that it suggests the values in your IDE.

That would be great. I think this should work, at least in Visual Studio Code:

appearance?: ValueOf<typeof ButtonAppearance> | (string & {});