-
Notifications
You must be signed in to change notification settings - Fork 76
Open
Description
The deltas are identical in both directions
I do not know if this is intended. I do not see it justified in the paper. This means, that backward deltas do not apply to backward mask. I have noticed you have inverted masks twice for backward input processing:
- first you invert masks when sending an argument to parse_rec function;
- then you reverse masks again in parse_delta in
if dir_ == 'backward'
So whatever bidirectional thing you calculate, the deltas do not align, so the temp decay is wrong, so the gammas... and so on.
Allow me to suggest creating tests using single dimensional data.
Reactions are currently unavailable
Metadata
Metadata
Assignees
Labels
No labels