Skip to content
This repository has been archived by the owner on Jan 28, 2024. It is now read-only.

non-blocking example #1

Open
codefromthecrypt opened this issue Nov 12, 2018 · 2 comments
Open

non-blocking example #1

codefromthecrypt opened this issue Nov 12, 2018 · 2 comments
Labels
enhancement New feature or request question Further information is requested

Comments

@codefromthecrypt
Copy link

Hi, your code looks neat.

This might not end up being a change here, but in our zipkin library we are working on a non-blocking rate limited implementation of sampling. For example, it returns true 1 time per second. I'm not sure if you have ambition for non-blocking. Also, we couldn't make a strict dependency, but it would be neat to get your input anyway. openzipkin/brave#819

@cap5lut cap5lut added enhancement New feature or request question Further information is requested labels Nov 12, 2018
@cap5lut
Copy link
Owner

cap5lut commented Nov 12, 2018

For the moment I do not plan to implement a non-blocking way. Plan for now was just to get rid of the busy wait in the blocking method and refactoring the state stuff to create less instance.

But once I'm going to think about that, I will give you a note.

@codefromthecrypt
Copy link
Author

codefromthecrypt commented Nov 13, 2018 via email

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
enhancement New feature or request question Further information is requested
Projects
None yet
Development

No branches or pull requests

2 participants