Fix PHPStand errors

Author: sebastianfeldmann

phpstan.neon

@@ -2,3 +2,5 @@ parameters:
   level: 7
   paths:
   - %currentWorkingDirectory%/src/
+  ignoreErrors:
+  - '#Property CaptainHook\\App\\Runner\\Hook\\PrepareCommitMsg::\$[a-zA-Z0-9\\_]+ is never read, only written.#'

src/Config.php

@@ -98,13 +98,13 @@ public function __construct(string $path, bool $fileExists = false, array $setti
     /**
      * Setup all configured plugins
      *
-     * @param  array<int, array<mixed>> $pluginSettings
+     * @param  array<int, array<string, mixed>> $pluginSettings
      * @return void
      */
     private function setupPlugins(array $pluginSettings): void
     {
         foreach ($pluginSettings as $plugin) {
-            $name                 = $plugin['plugin'];
+            $name                 = (string) $plugin['plugin'];
             $options              = isset($plugin['options']) && is_array($plugin['options'])
                 ? $plugin['options']
                 : [];

src/Config/Action.php

@@ -126,7 +126,7 @@ public function getJsonData(): array
     /**
      * Return conditions json data
      *
-     * @return array<int, array>
+     * @return array<int, mixed>
      */
     private function getConditionJsonData(): array
     {

src/Hook/PHP/CoverageResolver/CloverXML.php

@@ -77,6 +77,6 @@ public function getCoverage(): float
             );
         }
 
-        return $covered / ($statements * 0.01);
+        return $covered / ((int)$statements * 0.01);
     }
 }

src/Runner/Action/Cli/Command/Formatter.php

@@ -159,6 +159,7 @@ private function computedPlaceholder(string $rawPlaceholder): string
      */
     private function createPlaceholder(string $placeholder): Placeholder
     {
+        /** @var class-string<\CaptainHook\App\Runner\Action\Cli\Command\Placeholder> $class */
         $class = self::$placeholders[$placeholder];
         return new $class($this->config, $this->repository);
     }

src/Runner/Condition.php

@@ -100,6 +100,7 @@ private function createCondition(Config\Condition $config): ConditionInterface
             return new Cli(new Processor(), $config->getExec());
         }
 
+        /** @var class-string<\CaptainHook\App\Hook\Condition> $class */
         $class = $config->getExec();
         if (!class_exists($class)) {
             throw new RuntimeException('could not find condition class: ' . $class);

src/Runner/Config/Creator.php

@@ -49,7 +49,7 @@ class Creator extends Runner
     /**
      * Path to the currently executed 'binary'
      *
-     * @var string
+     * @var null|string
      */
     protected $executable;
 
@@ -178,7 +178,7 @@ private function ensureForce(): void
      *
      * @return string
      */
-    private function getExecutable()
+    private function getExecutable(): string
     {
         return $this->executable ?? 'vendor/bin/captainhook';
     }

src/Runner/Config/Editor.php

@@ -90,13 +90,14 @@ public function run(): void
     }
 
     /**
-     * Create an config edit command
+     * Create a config edit command
      *
      * @return \CaptainHook\App\Runner\Config\Change
      * @throws \RuntimeException
      */
     private function createChange(): Change
     {
+        /** @var class-string<\CaptainHook\App\Runner\Config\Change> $changeClass */
         $changeClass = '\\CaptainHook\\App\\Runner\\Config\\Change\\' . $this->change;
         if (!class_exists($changeClass)) {
             throw new RuntimeException('Invalid change requested');

src/Runner/Hook/PrepareCommitMsg.php

@@ -68,9 +68,9 @@ class PrepareCommitMsg extends Hook
     public function beforeHook(): void
     {
         $this->commentChar = $this->repository->getConfigOperator()->getSafely('core.commentchar', '#');
-        $this->file        = (string)$this->io->getArgument('file');
-        $this->mode        = (string)$this->io->getArgument('mode');
-        $this->hash        = (string)$this->io->getArgument('hash');
+        $this->file        = $this->io->getArgument('file');
+        $this->mode        = $this->io->getArgument('mode');
+        $this->hash        = $this->io->getArgument('hash');
 
         if (empty($this->file)) {
             throw new RuntimeException('commit message file argument is missing');