Skip to content

Conversation

@rpkilby
Copy link
Collaborator

@rpkilby rpkilby commented Mar 5, 2020

Alternate to #1176, fixes #1175.

Note that this might be made moot by #1118, although a similar test case should be incorporated.

@codecov-io
Copy link

codecov-io commented Mar 5, 2020

Codecov Report

Merging #1183 into master will increase coverage by <.01%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1183      +/-   ##
==========================================
+ Coverage   99.43%   99.44%   +<.01%     
==========================================
  Files          15       15              
  Lines        1243     1259      +16     
==========================================
+ Hits         1236     1252      +16     
  Misses          7        7
Impacted Files Coverage Δ
django_filters/filters.py 100% <100%> (ø) ⬆️
django_filters/widgets.py 100% <0%> (ø) ⬆️
django_filters/filterset.py 100% <0%> (ø) ⬆️
django_filters/conf.py 100% <0%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 400469f...d220f89. Read the comment docs.

@carltongibson
Copy link
Owner

My initial glance[*] at #1118 was that it looked super, so... — Let's leave this hanging for a bit.

[*]: didn't have time to give it it's due.

Base automatically changed from master to main March 3, 2021 08:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Bug in descending choices building for OrderingFilter

4 participants