Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add webhook page to docs #155

Open
hsluoyz opened this issue Mar 21, 2022 · 9 comments
Open

Add webhook page to docs #155

hsluoyz opened this issue Mar 21, 2022 · 9 comments
Assignees
Labels
enhancement New feature or request

Comments

@hsluoyz
Copy link
Member

hsluoyz commented Mar 21, 2022

See: https://door.casdoor.com/webhooks

@casbin-bot
Copy link

@ErikQQY

@casbin-bot casbin-bot added the enhancement New feature or request label Mar 21, 2022
@Jenniline
Copy link

Hi @hsluoyz
I am interested in working on this issue.

I see that this issue requires that one should know how to create a webhook and perform other actions to it. Which I will experiment on using my local setup.

I just have a few questions about this task. I have visited this page https://door.casdoor.com/webhooks
and what I will like to know is,

  1. Which part of the casdoor documentation should I add the webhooks documentation to?
    Should I create a directory for the webhooks inside the documentation, then in there I include the overview.md, and the other relevant pages?

I know I should document the process of creating a webhook and other actions relating to the webhooks.
2. Is there anything I should particularly take into consideration?

Thanks

@hsluoyz
Copy link
Member Author

hsluoyz commented Apr 21, 2022

@Jenniline similar answer as: #154 (comment)

@Jenniline
Copy link

Noted. with Thanks
I am on it

@hsluoyz
Copy link
Member Author

hsluoyz commented Apr 22, 2022

@Jenniline plz only work on one issue, we don't need to repeat the same words in two issues

@Jenniline
Copy link

okay noted
Thanks

@Jenniline
Copy link

Jenniline commented Apr 26, 2022

[Comment Updated]
Hi, @hsluoyz I am currently working on this issue, but I am a bit confused on the part about how Casdoor uses webhooks.
I have the casdoor project running locally and the casdoor-website running locally. That is what I am using to test the documentation I am working on.

Please can you help me with links that will aid me in better understanding how casdoor uses webhooks?
I have been searching but my search has not been fruitful.

Thanks

@hsluoyz
Copy link
Member Author

hsluoyz commented Apr 27, 2022

@Jenniline you need to read Casdoor source code, not Casbin

@Jenniline
Copy link

@hsluoyz Thank you for your reply.
I have made a PR for this issue here

Please review and let me know if there are any corrections I should make

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

3 participants