fix2

Author: 4xvgal

crates/cdk-integration-tests/tests/test_expose_private_channels.rs

@@ -1,12 +1,13 @@
 //! Test for CLN expose_private_channels feature
 //!
 //! Verifies that when expose_private_channels is enabled, bolt11 invoices
-//! always include route hints for private (unannounced) channels.
+//! include route hints for private (unannounced) channels.
 //!
 //! Topology:
 //!   CLN-1 has public channels (to LND-1, LND-2) and a private channel (to CLN-2).
-//!   With expose_private_channels=true, every invoice must include the private
-//!   channel route hint regardless of CLN's internal heuristics.
+//!   With expose_private_channels=true, private channels become route hint
+//!   candidates. CLN selects among all candidates per invoice, so the private
+//!   channel may not appear in every invoice but must appear in at least one.
 //!
 //! Requires regtest environment with CLN nodes running.
 
@@ -69,9 +70,12 @@ async fn test_expose_private_channels() -> Result<()> {
     // Create backend with expose_private_channels = true
     let cln_backend = create_cln_backend_with_options(&cln_one, true).await?;
 
-    // Generate 10 invoices and verify every one includes the private channel
-    // route hint. This guards against non-deterministic route hint selection.
+    // Generate 10 invoices. CLN selects route hints from all candidates
+    // (public + private), so the private channel won't appear in every
+    // invoice. We verify it appears in at least one.
     let num_invoices = 10;
+    let mut private_hint_count = 0;
+
     for i in 0..num_invoices {
         let amount = cdk_common::amount::Amount::new(10_000, CurrencyUnit::Msat);
         let response = cln_backend
@@ -87,29 +91,31 @@ async fn test_expose_private_channels() -> Result<()> {
         let invoice = Bolt11Invoice::from_str(&response.request)?;
         let hints = invoice.route_hints();
 
-        // Debug: print route hint pubkeys vs expected CLN-2 pubkey
-        for (j, hint) in hints.iter().enumerate() {
-            for hop in &hint.0 {
-                println!(
-                    "Invoice {i}, hint {j}: src_node_id={}, expected={}",
-                    hop.src_node_id, cln_two_info.pubkey
-                );
-            }
-        }
-
         let has_private_channel_hint = hints.iter().any(|hint| {
             hint.0
                 .iter()
                 .any(|hop| hop.src_node_id.to_string() == cln_two_info.pubkey)
         });
 
-        assert!(
-            has_private_channel_hint,
-            "Invoice {i}: route hints should include private channel with CLN-2. \
-             Got {} route hints",
+        if has_private_channel_hint {
+            private_hint_count += 1;
+        }
+
+        println!(
+            "Invoice {i}: private_channel_hint={has_private_channel_hint}, total_hints={}",
             hints.len()
         );
     }
 
+    assert!(
+        private_hint_count > 0,
+        "None of {num_invoices} invoices included the private channel route hint. \
+         expose_private_channels=true should make private channels route hint candidates."
+    );
+
+    println!(
+        "Private channel appeared in {private_hint_count}/{num_invoices} invoices"
+    );
+
     Ok(())
 }