Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Expose lib.ctp to config.lib.ctp #167

Closed
Weathercold opened this issue May 9, 2024 · 2 comments
Closed

Expose lib.ctp to config.lib.ctp #167

Weathercold opened this issue May 9, 2024 · 2 comments

Comments

@Weathercold
Copy link
Contributor

I'm working on exposing lib to config instead of extending nixpkgs' lib so that users can have access to some useful functions like mkUpper

@getchoo are you open to this?

@getchoo
Copy link
Member

getchoo commented May 10, 2024

most of my thoughts can be summed up here #96 (comment) and in a PR that implemented this already

as a tl;dr (and more specific to our library): exposing our lib to config wouldn't make much sense imo, as it's not an actual option. a proper way to do this would be a pure flake output or an importable version -- the latter of which we do have and can be used by others, but i understand it's not a nice way to do it

i don't think we should explicitly expose our lib in general though, as that would give us a much broader public api (and thus more pressure to keep it stable), and honestly? i'm not sure how useful most of our functions are. there are a few like you mentioned with mkUpper, but in general this isn't the case. i would also say it's a bit out of scope for this project to provide general utilities

@Weathercold
Copy link
Contributor Author

Good point

@Weathercold Weathercold closed this as not planned Won't fix, can't repro, duplicate, stale May 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants