-
-
Notifications
You must be signed in to change notification settings - Fork 223
Open
Description
circle CI is running this:
yarn test --silent --updateSnapshot --runInBand --no-watchman --testPathPattern="/Board|Communicator|App|Settings|Account|UI/"
which is updating the snapshots as part of the test process. Meaning that the snapshot testing is always forced to pass.
I ran those tests in master branch and it's updating two snapshots:
➜ cboard git:(master) ✗ gst
On branch master
Your branch is up to date with 'origin/master'.
Changes not staged for commit:
(use "git add <file>..." to update what will be committed)
(use "git restore <file>..." to discard changes in working directory)
modified: src/components/Communicator/CommunicatorDialog/__snapshots__/CommunicatorDialog.test.js.snap
modified: src/components/Settings/Navigation/__snapshots__/Navigation.test.js.snap
- Should we remove all snapshot tests?
or - Update circle CI and current snapshots?
Metadata
Metadata
Assignees
Labels
No labels