Skip to content

Snapshot tests aren't being used #1656

@maxicapodacqua

Description

@maxicapodacqua

circle CI is running this:

yarn test --silent --updateSnapshot --runInBand --no-watchman --testPathPattern="/Board|Communicator|App|Settings|Account|UI/"

which is updating the snapshots as part of the test process. Meaning that the snapshot testing is always forced to pass.

I ran those tests in master branch and it's updating two snapshots:

➜  cboard git:(master) ✗ gst
On branch master
Your branch is up to date with 'origin/master'.

Changes not staged for commit:
  (use "git add <file>..." to update what will be committed)
  (use "git restore <file>..." to discard changes in working directory)
        modified:   src/components/Communicator/CommunicatorDialog/__snapshots__/CommunicatorDialog.test.js.snap
        modified:   src/components/Settings/Navigation/__snapshots__/Navigation.test.js.snap
  • Should we remove all snapshot tests?
    or
  • Update circle CI and current snapshots?

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions