Conversation
These QC rules are still very ad hoc -- more work needed.
divine7022
requested changes
Feb 25, 2026
Comment on lines
+81
to
+88
| function(site_id, start_date, end_date, ens_id, ...) { | ||
| PEcAn.SIPNET::met2model.SIPNET( | ||
| in.path = file.path( | ||
| args$site_era5_path, | ||
| paste("ERA5", site_id, ens_id, sep = "_") | ||
| ), | ||
| start_date = args$start_date, | ||
| end_date = args$end_date, |
Contributor
There was a problem hiding this comment.
function signature binds start_date and end_date from file_info, but lines 87-88 ignore them and use args$start_date / args$end_date instead; this works but is misleading, consider using the function parameter or removing it from the signature. (same pattern exists in 2a_grass/01_ERA5_nc_to_clim.R was this intentionally inherited?)
Contributor
Author
There was a problem hiding this comment.
fixed locally, will be in next PR
| facet_wrap(~site) + | ||
| theme_bw() + | ||
| ylab("LAI") + | ||
| xlab("DOY") + |
Contributor
There was a problem hiding this comment.
trailing + on the last ggplot layer save_gg(...) will be parsed as a ggplot layer addition and throw an error
Suggested change
| xlab("DOY") + | |
| xlab("DOY") |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.