Cmake fix #1
Cmake fix #1
Conversation
| @@ -157,6 +157,12 @@ set(common_includes | |||
| ${TRACY_PUBLIC_DIR}/common/TracyUwp.hpp | |||
| ${TRACY_PUBLIC_DIR}/common/TracyYield.hpp) | |||
|
|
|||
| if(CMAKE_SYSTEM_NAME STREQUAL "Windows") | |||
There was a problem hiding this comment.
I'm not sure this is the best way to do this. I need to differentiate otherwise it will overwrite the files for different os.
|
There are probably better ways to do this. I didn't really want to include our branch to grab the cmake utilities we have their, rather keep this independent but feel free to rip this apart. We do need to differentiate where we put the config though otherwise the "last thing unzipped" will just overwrite it and in our case we were trying to import a .dll on a windows system |
|
Wait, why are we modifying Tracy here? Those changes are a maintenance burden we don't want to take on. Any changes that are required because of our vendoring constraints need to happen in our own pipelines when we do the vendoring, and not as part of the library we vendor. |
|
Agreed and there is probably another way to do this that I'm not seeing. We install the tracy config into Which happens both for windows and macos. What it installs is in Config.cmake.in. Oh we can probably just change the CMAKE_INSTALL_PREFIX to include windows and macos and then do the "branching" in CcpGlobalSettings? |
|
or really just set the CMAKE_INSTALL_DATAROOTDIR |
Perhaps this is possible, and would be a good approach. Alternately, if that doesn't work out, then we might be able to copy files around during the publish process. I am not familiar with how that is currently set up, but usually that isn't very difficult as it can be as simple as an additional build step in the given TeamCity configuration. |
No description provided.