Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Utilize inheritance where needed #64

Open
xibz opened this issue Jan 5, 2024 · 1 comment
Open

Utilize inheritance where needed #64

xibz opened this issue Jan 5, 2024 · 1 comment

Comments

@xibz
Copy link

xibz commented Jan 5, 2024

Subject classes for build events do not have a proper parent.

For example

and https://github.com/cdevents/sdk-java/blob/5d17b750fda57fd4a9d7ad2c5baec2bb4b9e2143/sdk/src/main/java/dev/cdevents/models/build/started/Subject.java are very similar. These classes should have a parent class that handles the intersection between all subject object in all events. As in the type, id, source, etc. These should all live on a parent. This is an issue in various other places. I imagine Context has the same problem. We should definitely change how this behaves and how these classes are generated

@aalmiray
Copy link
Contributor

Likely related to the current source generator based on jsonschema2pojo. Unfortunately the plugin's documentation does not mention a setting for handling this use case.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants