Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SDK: Missing examples of sending events #94

Open
m-linner-ericsson opened this issue Sep 7, 2021 · 5 comments
Open

SDK: Missing examples of sending events #94

m-linner-ericsson opened this issue Sep 7, 2021 · 5 comments
Labels
documentation Improvements or additions to documentation good first issue Good for newcomers

Comments

@m-linner-ericsson
Copy link
Collaborator

In the readme for the SDK we list examples of how to send events. The SDK does support more events than listed in the examples.

To resolve this issue add examples for sending the other event types.

@m-linner-ericsson m-linner-ericsson added good first issue Good for newcomers documentation Improvements or additions to documentation labels Sep 7, 2021
@nathannaveen
Copy link
Contributor

I would like to work on this.

@nathannaveen
Copy link
Contributor

I was looking into this and noticed that taskrun events have examples for queued while the cli does not.

Which of these is correct, the example or the code?

go run main.go taskrun 
Emit TaskRun related CloudEvent

Usage:
  cde taskrun [command]

Available Commands:
  finished    Emit TaskRun Finished Event
  started     Emit TaskRun Started Event

Flags:
  -d, --data stringToString   Task Run's Data (default [])
  -h, --help                  help for taskrun
  -i, --id string             Task Run Id
  -n, --name string           Task Run's Name
  -p, --pipelineid string     Task Run's Pipeline Id

Global Flags:
      --config string   config file (default is $HOME/.cde.yaml)

Use "cde taskrun [command] --help" for more information about a command.

@m-linner-ericsson
Copy link
Collaborator Author

@nathan-415 There were some inconsistencies that were fixed by #84 (merged the 9:th) could this answer your questions?

@e-backmark-ericsson
Copy link
Collaborator

Is this issue still valid, @m-linner-ericsson, @nathannaveen , @afrittoli ? If so, it should be re-created in the cdevents/sdk-go repo

@m-linner-ericsson
Copy link
Collaborator Author

If we solve #129 this would not be an issue any longer.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation good first issue Good for newcomers
Projects
None yet
Development

No branches or pull requests

3 participants