-
Notifications
You must be signed in to change notification settings - Fork 89
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Deprecation of rofi-script mode #240
Comments
I don't use this any more. |
I don’t use it, but I just tested it to see what it was and I think it is already supported with the current version of clipmenu 7. You just need to wrap clipmenu in a small script #!/bin/bash
if [[ $# -eq 0 ]]; then
# Step 1: Get list of items from clipmenu
env CM_LAUNCHER='clipmenu-rofi-script-aux1' clipmenu
cat < "$XDG_RUNTIME_DIR/clipmenu-rofi-script.list"
else
# Step 2: Tell clipmenu which item was selected
{
export CLIPMENU_ROFI_SCRIPT_CHOSEN_LINE="$1"
export CM_LAUNCHER='clipmenu-rofi-script-aux2'
clipmenu >/dev/null 2>&1
} &
fi where #!/bin/bash
cat > "$XDG_RUNTIME_DIR/clipmenu-rofi-script.list"
exit 1 and #!/bin/bash
echo "$CLIPMENU_ROFI_SCRIPT_CHOSEN_LINE" Then you can use rofi-script in the following way:
I may have entirely missed the point… |
The problem with that is that the chosen line index races with addition of any new entry. That's the bit I mention about complicating the locking strategy :) |
But it's true that anyone who has this problem can use this script if they want support, even if it is racy. So while it can't have first party support, it's a good stopgap. Thanks! |
Normal rofi usage is unaffected, this is only for CM_LAUNCHER=rofi-script users.
This is a call for anyone who uses rofi-script mode to discuss the use case. Currently there is no support in clipmenu 7 as it significantly complicates locking strategy. There are ways to make it work, but they are complex, and I'm not immediately seeing the benefits of rofi-script mode over normal rofi use. It was mentioned it allows rofi to tab, but that seems like something rofi could in theory support even outside of script mode.
So, if there is some reason it should be kept, please make it known in the coming days :-)
Cc @RX14 who originally implemented it
The text was updated successfully, but these errors were encountered: