From 2cab5385ee6112659eb7768fe1446346b13ef9bc Mon Sep 17 00:00:00 2001 From: sweexordious Date: Fri, 19 Jul 2024 11:32:59 +0100 Subject: [PATCH] docs: add go doc --- pkg/proof/proof_test.go | 7 +++++++ pkg/proof/querier.go | 5 +++-- 2 files changed, 10 insertions(+), 2 deletions(-) diff --git a/pkg/proof/proof_test.go b/pkg/proof/proof_test.go index 405c630929..0a0c098912 100644 --- a/pkg/proof/proof_test.go +++ b/pkg/proof/proof_test.go @@ -147,6 +147,13 @@ func TestNewShareInclusionProof(t *testing.T) { namespaceID: appns.TxNamespace, expectErr: true, }, + { + name: "ending share is equal to the starting share", + startingShare: 1, + endingShare: 1, + namespaceID: appns.TxNamespace, + expectErr: true, + }, { name: "ending share higher than number of shares available in square size of 32", startingShare: 0, diff --git a/pkg/proof/querier.go b/pkg/proof/querier.go index 7bca88f114..b4c2a233dd 100644 --- a/pkg/proof/querier.go +++ b/pkg/proof/querier.go @@ -123,13 +123,14 @@ func QueryShareInclusionProof(_ sdk.Context, path []string, req abci.RequestQuer // ParseNamespace validates the share range, checks if it only contains one namespace and returns // that namespace ID. +// The provided range, defined by startShare and endShare, is end-exclusive. func ParseNamespace(rawShares []shares.Share, startShare, endShare int) (appns.Namespace, error) { if startShare < 0 { return appns.Namespace{}, fmt.Errorf("start share %d should be positive", startShare) } - if endShare < 0 { - return appns.Namespace{}, fmt.Errorf("end share %d should be positive", endShare) + if endShare <= startShare { + return appns.Namespace{}, fmt.Errorf("end share %d cannot be lower or equal to the starting share %d", endShare, startShare) } if endShare < startShare {