Some retroactive nits/questions

[liamsi]

Summary

I had some time to go through each package while I was on a flight not long ago. I'll collect some observations/feedback here. I'm drop my raw notes here as otherwise I won't find the time to write them up more nicely.

Feedback/Questions

• Is listener the right name for sth that also broadcasts to the network?
  celestia-node/core_listener.go at af0277b15ec17214965ef15083a2cd2f31b9f93f · celestiaorg/celestia-node

  celestia-node/service/header/core_listener.go

  Line 87 in b71470e

  err = cl.bcast.Broadcast(ctx, eh)

• cel-shed: the name will still very unclear to newbies IMO.

• bridge: Should be clear on first sight what this is (bridge usually means sth else in a crypto context)

• core: Mostly deals with app/tendermint interaction and init but core would rather be expected to be core to the protocol. Also what is the relation of the core package and node/core package?

• Is there an issue about removing fxutil? celestia-node/options.go at e0c8c0e43971294748a5a711a8ffb090748fdb4f · celestiaorg/celestia-node; also SupplyIf doesn't seem to be not used

• logs: why are these hardcoded? What if these names changed?

  celestia-node/logs/logs.go

  Line 5 in b71470e

  func SetAllLoggers(level logging.LogLevel) {

• should the config in p2p.go be moved into config.go?

• core Init: this should not just take DefaultParams but actually the params from the app

• why does the logger sometimes also has prefixes? e.g. core: here: celestia-node/core_exchange.go at af0277b15ec17214965ef15083a2cd2f31b9f93f · celestiaorg/celestia-node

• Naming: why Root type alias for DAHeader? celestia-node/share.go at ffe8522da05a03c7220103119cbe88fdd6ba4211 · celestiaorg/celestia-node

• relation of Node/services and service?

• should the SampleAmount be a user param? There should be a lower bound maybe but other than that users should be able to set this param (at launch at least):
  celestia-node/light_availability.go at ffe8522da05a03c7220103119cbe88fdd6ba4211 · celestiaorg/celestia-node

Urgency

Low