Skip to content

Commit f950cc9

Browse files
KaiSchwarz-cnicKaiSchwarz-cnic
authored
Merge pull request #18 from centralnic-reseller/paginationcolsreview
refactor(columns): review getListHash to ignore pagination cols in da…
2 parents 37685dd + 46af7bf commit f950cc9

28 files changed

+4379
-4161
lines changed

‎reports/clover/coverage.xml‎

Lines changed: 732 additions & 727 deletions
Large diffs are not rendered by default.

‎reports/html/CNR/SessionClient.php.html‎

Lines changed: 104 additions & 104 deletions
Large diffs are not rendered by default.

‎reports/html/CNR/dashboard.html‎

Lines changed: 13 additions & 16 deletions
Original file line numberDiff line numberDiff line change
@@ -58,7 +58,7 @@ <h3>Insufficient Coverage</h3>
5858
</tr>
5959
</thead>
6060
<tbody>
61-
<tr><td><a href="SessionClient.php.html#18">CNIC\CNR\SessionClient</a></td><td class="text-right">0%</td></tr>
61+
<tr><td><a href="SessionClient.php.html#18">CNIC\CNR\SessionClient</a></td><td class="text-right">85%</td></tr>
6262

6363
</tbody>
6464
</table>
@@ -75,7 +75,7 @@ <h3>Project Risks</h3>
7575
</tr>
7676
</thead>
7777
<tbody>
78-
<tr><td><a href="SessionClient.php.html#18">CNIC\CNR\SessionClient</a></td><td class="text-right">756</td></tr>
78+
<tr><td><a href="SessionClient.php.html#18">CNIC\CNR\SessionClient</a></td><td class="text-right">29</td></tr>
7979

8080
</tbody>
8181
</table>
@@ -113,12 +113,10 @@ <h3>Insufficient Coverage</h3>
113113
</tr>
114114
</thead>
115115
<tbody>
116-
<tr><td><a href="SessionClient.php.html#20"><abbr title="CNIC\CNR\SessionClient::__construct">__construct</abbr></a></td><td class="text-right">0%</td></tr>
117-
<tr><td><a href="SessionClient.php.html#29"><abbr title="CNIC\CNR\SessionClient::login">login</abbr></a></td><td class="text-right">0%</td></tr>
118116
<tr><td><a href="SessionClient.php.html#50"><abbr title="CNIC\CNR\SessionClient::loginExtended">loginExtended</abbr></a></td><td class="text-right">0%</td></tr>
119-
<tr><td><a href="SessionClient.php.html#60"><abbr title="CNIC\CNR\SessionClient::logout">logout</abbr></a></td><td class="text-right">0%</td></tr>
120-
<tr><td><a href="SessionClient.php.html#74"><abbr title="CNIC\CNR\SessionClient::IDNConvert">IDNConvert</abbr></a></td><td class="text-right">0%</td></tr>
121-
<tr><td><a href="SessionClient.php.html#119"><abbr title="CNIC\CNR\SessionClient::autoIDNConvert">autoIDNConvert</abbr></a></td><td class="text-right">0%</td></tr>
117+
<tr><td><a href="SessionClient.php.html#29"><abbr title="CNIC\CNR\SessionClient::login">login</abbr></a></td><td class="text-right">66%</td></tr>
118+
<tr><td><a href="SessionClient.php.html#60"><abbr title="CNIC\CNR\SessionClient::logout">logout</abbr></a></td><td class="text-right">75%</td></tr>
119+
<tr><td><a href="SessionClient.php.html#74"><abbr title="CNIC\CNR\SessionClient::IDNConvert">IDNConvert</abbr></a></td><td class="text-right">86%</td></tr>
122120

123121
</tbody>
124122
</table>
@@ -135,10 +133,9 @@ <h3>Project Risks</h3>
135133
</tr>
136134
</thead>
137135
<tbody>
138-
<tr><td><a href="SessionClient.php.html#119"><abbr title="CNIC\CNR\SessionClient::autoIDNConvert">autoIDNConvert</abbr></a></td><td class="text-right">132</td></tr>
139-
<tr><td><a href="SessionClient.php.html#74"><abbr title="CNIC\CNR\SessionClient::IDNConvert">IDNConvert</abbr></a></td><td class="text-right">90</td></tr>
140-
<tr><td><a href="SessionClient.php.html#29"><abbr title="CNIC\CNR\SessionClient::login">login</abbr></a></td><td class="text-right">12</td></tr>
141-
<tr><td><a href="SessionClient.php.html#60"><abbr title="CNIC\CNR\SessionClient::logout">logout</abbr></a></td><td class="text-right">6</td></tr>
136+
<tr><td><a href="SessionClient.php.html#74"><abbr title="CNIC\CNR\SessionClient::IDNConvert">IDNConvert</abbr></a></td><td class="text-right">9</td></tr>
137+
<tr><td><a href="SessionClient.php.html#29"><abbr title="CNIC\CNR\SessionClient::login">login</abbr></a></td><td class="text-right">3</td></tr>
138+
<tr><td><a href="SessionClient.php.html#60"><abbr title="CNIC\CNR\SessionClient::logout">logout</abbr></a></td><td class="text-right">2</td></tr>
142139

143140
</tbody>
144141
</table>
@@ -148,7 +145,7 @@ <h3>Project Risks</h3>
148145
<footer>
149146
<hr/>
150147
<p>
151-
<small>Generated by <a href="https://github.com/sebastianbergmann/php-code-coverage" target="_top">php-code-coverage 9.2.15</a> using <a href="https://secure.php.net/" target="_top">PHP 7.4.32</a> and <a href="https://phpunit.de/">PHPUnit 9.5.21</a> at Thu Oct 20 21:32:42 CEST 2022.</small>
148+
<small>Generated by <a href="https://github.com/sebastianbergmann/php-code-coverage" target="_top">php-code-coverage 9.2.15</a> using <a href="https://secure.php.net/" target="_top">PHP 7.4.32</a> and <a href="https://phpunit.de/">PHPUnit 9.5.21</a> at Thu Oct 20 22:19:11 CEST 2022.</small>
152149
</p>
153150
</footer>
154151
</div>
@@ -167,7 +164,7 @@ <h3>Project Risks</h3>
167164
.yAxis.tickFormat(d3.format('d'));
168165

169166
d3.select('#classCoverageDistribution svg')
170-
.datum(getCoverageDistributionData([1,0,0,0,0,0,0,0,0,0,0,0], "Class Coverage"))
167+
.datum(getCoverageDistributionData([0,0,0,0,0,0,0,0,0,1,0,0], "Class Coverage"))
171168
.transition().duration(500).call(chart);
172169

173170
nv.utils.windowResize(chart.update);
@@ -185,7 +182,7 @@ <h3>Project Risks</h3>
185182
.yAxis.tickFormat(d3.format('d'));
186183

187184
d3.select('#methodCoverageDistribution svg')
188-
.datum(getCoverageDistributionData([6,0,0,0,0,0,0,0,0,0,0,0], "Method Coverage"))
185+
.datum(getCoverageDistributionData([1,0,0,0,0,0,0,1,1,1,1,1], "Method Coverage"))
189186
.transition().duration(500).call(chart);
190187

191188
nv.utils.windowResize(chart.update);
@@ -235,7 +232,7 @@ <h3>Project Risks</h3>
235232
chart.yAxis.axisLabel('Cyclomatic Complexity');
236233

237234
d3.select('#classComplexity svg')
238-
.datum(getComplexityData([[0,27,"<a href=\"SessionClient.php.html#18\">CNIC\\CNR\\SessionClient<\/a>"]], 'Class Complexity'))
235+
.datum(getComplexityData([[85.45454545454545,27,"<a href=\"SessionClient.php.html#18\">CNIC\\CNR\\SessionClient<\/a>"]], 'Class Complexity'))
239236
.transition()
240237
.duration(500)
241238
.call(chart);
@@ -259,7 +256,7 @@ <h3>Project Risks</h3>
259256
chart.yAxis.axisLabel('Method Complexity');
260257

261258
d3.select('#methodComplexity svg')
262-
.datum(getComplexityData([[0,1,"<a href=\"SessionClient.php.html#20\">CNIC\\CNR\\SessionClient::__construct<\/a>"],[0,3,"<a href=\"SessionClient.php.html#29\">CNIC\\CNR\\SessionClient::login<\/a>"],[0,1,"<a href=\"SessionClient.php.html#50\">CNIC\\CNR\\SessionClient::loginExtended<\/a>"],[0,2,"<a href=\"SessionClient.php.html#60\">CNIC\\CNR\\SessionClient::logout<\/a>"],[0,9,"<a href=\"SessionClient.php.html#74\">CNIC\\CNR\\SessionClient::IDNConvert<\/a>"],[0,11,"<a href=\"SessionClient.php.html#119\">CNIC\\CNR\\SessionClient::autoIDNConvert<\/a>"]], 'Method Complexity'))
259+
.datum(getComplexityData([[100,1,"<a href=\"SessionClient.php.html#20\">CNIC\\CNR\\SessionClient::__construct<\/a>"],[66.66666666666666,3,"<a href=\"SessionClient.php.html#29\">CNIC\\CNR\\SessionClient::login<\/a>"],[0,1,"<a href=\"SessionClient.php.html#50\">CNIC\\CNR\\SessionClient::loginExtended<\/a>"],[75,2,"<a href=\"SessionClient.php.html#60\">CNIC\\CNR\\SessionClient::logout<\/a>"],[86.36363636363636,9,"<a href=\"SessionClient.php.html#74\">CNIC\\CNR\\SessionClient::IDNConvert<\/a>"],[95.23809523809523,11,"<a href=\"SessionClient.php.html#119\">CNIC\\CNR\\SessionClient::autoIDNConvert<\/a>"]], 'Method Complexity'))
263260
.transition()
264261
.duration(500)
265262
.call(chart);

‎reports/html/CNR/index.html‎

Lines changed: 21 additions & 21 deletions
Original file line numberDiff line numberDiff line change
@@ -43,23 +43,23 @@
4343
</thead>
4444
<tbody>
4545
<tr>
46-
<td class="danger">Total</td>
47-
<td class="danger big"> <div class="progress">
48-
<div class="progress-bar bg-danger" role="progressbar" aria-valuenow="0.00" aria-valuemin="0" aria-valuemax="100" style="width: 0.00%">
49-
<span class="sr-only">0.00% covered (danger)</span>
46+
<td class="warning">Total</td>
47+
<td class="warning big"> <div class="progress">
48+
<div class="progress-bar bg-warning" role="progressbar" aria-valuenow="85.45" aria-valuemin="0" aria-valuemax="100" style="width: 85.45%">
49+
<span class="sr-only">85.45% covered (warning)</span>
5050
</div>
5151
</div>
5252
</td>
53-
<td class="danger small"><div align="right">0.00%</div></td>
54-
<td class="danger small"><div align="right">0&nbsp;/&nbsp;55</div></td>
53+
<td class="warning small"><div align="right">85.45%</div></td>
54+
<td class="warning small"><div align="right">47&nbsp;/&nbsp;55</div></td>
5555
<td class="danger big"> <div class="progress">
56-
<div class="progress-bar bg-danger" role="progressbar" aria-valuenow="0.00" aria-valuemin="0" aria-valuemax="100" style="width: 0.00%">
57-
<span class="sr-only">0.00% covered (danger)</span>
56+
<div class="progress-bar bg-danger" role="progressbar" aria-valuenow="16.67" aria-valuemin="0" aria-valuemax="100" style="width: 16.67%">
57+
<span class="sr-only">16.67% covered (danger)</span>
5858
</div>
5959
</div>
6060
</td>
61-
<td class="danger small"><div align="right">0.00%</div></td>
62-
<td class="danger small"><div align="right">0&nbsp;/&nbsp;6</div></td>
61+
<td class="danger small"><div align="right">16.67%</div></td>
62+
<td class="danger small"><div align="right">1&nbsp;/&nbsp;6</div></td>
6363
<td class="danger big"> <div class="progress">
6464
<div class="progress-bar bg-danger" role="progressbar" aria-valuenow="0.00" aria-valuemin="0" aria-valuemax="100" style="width: 0.00%">
6565
<span class="sr-only">0.00% covered (danger)</span>
@@ -71,23 +71,23 @@
7171
</tr>
7272

7373
<tr>
74-
<td class="danger"><img src="../_icons/file-code.svg" class="octicon" /><a href="SessionClient.php.html">SessionClient.php</a></td>
75-
<td class="danger big"> <div class="progress">
76-
<div class="progress-bar bg-danger" role="progressbar" aria-valuenow="0.00" aria-valuemin="0" aria-valuemax="100" style="width: 0.00%">
77-
<span class="sr-only">0.00% covered (danger)</span>
74+
<td class="warning"><img src="../_icons/file-code.svg" class="octicon" /><a href="SessionClient.php.html">SessionClient.php</a></td>
75+
<td class="warning big"> <div class="progress">
76+
<div class="progress-bar bg-warning" role="progressbar" aria-valuenow="85.45" aria-valuemin="0" aria-valuemax="100" style="width: 85.45%">
77+
<span class="sr-only">85.45% covered (warning)</span>
7878
</div>
7979
</div>
8080
</td>
81-
<td class="danger small"><div align="right">0.00%</div></td>
82-
<td class="danger small"><div align="right">0&nbsp;/&nbsp;55</div></td>
81+
<td class="warning small"><div align="right">85.45%</div></td>
82+
<td class="warning small"><div align="right">47&nbsp;/&nbsp;55</div></td>
8383
<td class="danger big"> <div class="progress">
84-
<div class="progress-bar bg-danger" role="progressbar" aria-valuenow="0.00" aria-valuemin="0" aria-valuemax="100" style="width: 0.00%">
85-
<span class="sr-only">0.00% covered (danger)</span>
84+
<div class="progress-bar bg-danger" role="progressbar" aria-valuenow="16.67" aria-valuemin="0" aria-valuemax="100" style="width: 16.67%">
85+
<span class="sr-only">16.67% covered (danger)</span>
8686
</div>
8787
</div>
8888
</td>
89-
<td class="danger small"><div align="right">0.00%</div></td>
90-
<td class="danger small"><div align="right">0&nbsp;/&nbsp;6</div></td>
89+
<td class="danger small"><div align="right">16.67%</div></td>
90+
<td class="danger small"><div align="right">1&nbsp;/&nbsp;6</div></td>
9191
<td class="danger big"> <div class="progress">
9292
<div class="progress-bar bg-danger" role="progressbar" aria-valuenow="0.00" aria-valuemin="0" aria-valuemax="100" style="width: 0.00%">
9393
<span class="sr-only">0.00% covered (danger)</span>
@@ -111,7 +111,7 @@ <h4>Legend</h4>
111111
<span class="success"><strong>High</strong>: 90% to 100%</span>
112112
</p>
113113
<p>
114-
<small>Generated by <a href="https://github.com/sebastianbergmann/php-code-coverage" target="_top">php-code-coverage 9.2.15</a> using <a href="https://secure.php.net/" target="_top">PHP 7.4.32</a> and <a href="https://phpunit.de/">PHPUnit 9.5.21</a> at Thu Oct 20 21:32:42 CEST 2022.</small>
114+
<small>Generated by <a href="https://github.com/sebastianbergmann/php-code-coverage" target="_top">php-code-coverage 9.2.15</a> using <a href="https://secure.php.net/" target="_top">PHP 7.4.32</a> and <a href="https://phpunit.de/">PHPUnit 9.5.21</a> at Thu Oct 20 22:19:11 CEST 2022.</small>
115115
</p>
116116
</footer>
117117
</div>

0 commit comments

Comments
 (0)